Bug 235711 - [PATCH] dns/dsc Update to 2.8.0 and patching a patch
Summary: [PATCH] dns/dsc Update to 2.8.0 and patching a patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Craig Leres
URL: https://lists.dns-oarc.net/pipermail/...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-13 10:08 UTC by Leo Vandewoestijne
Modified: 2019-02-14 17:01 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+

Attachments
dsc 2.8.0 (1.68 KB, text/plain)
2019-02-13 10:08 UTC, Leo Vandewoestijne 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2019-02-13 10:08:42 UTC 
Created attachment 201981 [details]
dsc 2.8.0

And just about an hour after the previous commit (PR 234950), I discover that the vendor faced the same problem, and released a new version.

So I'd:

- upgraded the version from 2.7.0 to 2.8.0

- Regenerated the patch for cron/upload-prep.pl

- replaced spaces with tab in Makefile

Tested in poudriere (11.2 & 12.0 / amd64 & i386).
Comment 1 Leo Vandewoestijne 2019-02-13 10:28:00 UTC 
Side-note to leres:

Do know that I do reply politely to your messages, however always get 550's:

<leres@xse.com>: host xse.com[2607:f2f8:abb8::3] said: 550 5.7.1
    <freebsd@dns.company>... fail (in reply to MAIL FROM command)

JFYI
Comment 2 Craig Leres freebsd_committer freebsd_triage 2019-02-13 20:24:14 UTC 
dns.company has a SPF TXT record and your messages to me fail the SPF check when mx2.freebsd.org tries to relay them.

    Feb 13 02:22:48 dot.xse.com sm-mta[61487]: x1DAMmi0061487: mx2.freebsd.org [IPv6:2001:1900:2254:206a:0:0:19:2] "MAIL FROM:<freebsd@dns.company> SIZE=4744"
    Feb 13 02:22:49 dot.xse.com sm-mta[61487]: x1DAMmi0061487: Milter: from=<freebsd@dns.company>, reject=550 5.7.1 fail
    Feb 13 02:22:49 dot.xse.com sm-mta[61487]: x1DAMmi0061487: from=<freebsd@dns.company>, size=4744, class=0, nrcpts=0, proto=ESMTPS, daemon=MTA6, relay=mx2.freebsd.org [IPv6:2001:1900:2254:206a:0:0:19:2]

This is a fairly widespread problem with the way bugs.freebsd.org works, I would imagine.
Comment 3 Craig Leres freebsd_committer freebsd_triage 2019-02-13 22:24:04 UTC 
As per offline discussion.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-14 00:46:17 UTC 
A commit references this bug:

Author: leres
Date: Thu Feb 14 00:45:53 UTC 2019
New revision: 492892
URL: https://svnweb.freebsd.org/changeset/ports/492892

Log:
  Upgrade to 2.8.0:

   - New indexer 'response_time'

   - Support for MaxMind DB (GeoIP2)

   - Update 'pcap_layers' with fixes for 'scan-build' warnings

   - Fix port in debug output of DNS message

  Changes made in addition to the PR supplied patch:

   - The port had USES=shebangfix but none of the SHEBANG_ variables
     were set; replace the cron_upload-prep.pl patch with a working
     shebangfix setup and then use REINPLACE_CMD to adjust the conf
     path in upload-prep.pl

   - While we're here use REINPLACE_CMD to obey PREFIX in other
     files

  PR:		235711
  Submitted by:	Leo Vandewoestijne (maintainer)
  Reviewed by:	ler (mentor)
  Approved by:	ler (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19187

Changes:
  head/dns/dsc/Makefile
  head/dns/dsc/distinfo
  head/dns/dsc/files/patch-cron_upload-prep.pl
Comment 5 Craig Leres freebsd_committer freebsd_triage 2019-02-14 17:01:27 UTC 
Thanks for the patch!

BTW it's worth checking the "patch" box when attaching the patch otherwise whitespace gets mangled.