Bug 235839 - x11-drivers/xf86-video-apm: Update to 1.3.0
Summary: x11-drivers/xf86-video-apm: Update to 1.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-18 18:39 UTC by pete
Modified: 2019-02-20 20:00 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
update to v1.3.0 (985 bytes, patch)
2019-02-18 18:39 UTC, pete
no flags Details | Diff
build logs. (33.56 KB, text/plain)
2019-02-18 20:29 UTC, pete
no flags Details
updated patch to fix issues with 1st attempt. (3.87 KB, patch)
2019-02-18 20:51 UTC, pete
no flags Details | Diff
poudriere build log (33.49 KB, text/plain)
2019-02-18 20:52 UTC, pete
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description pete 2019-02-18 18:39:26 UTC
Created attachment 202132 [details]
update to v1.3.0

maint release of APM video driver.  This will most likely cease as this will not compile against xorg-server-1.20.  Building now and will update ticket if this successfully builds.

Up stream release notes:

https://lists.x.org/archives/xorg-announce/2019-February/002939.html


This is a maintenance release of Alliance Semiconductor ProMotion DDX for X.Org X Server.
No testing has been done due to the lack of equipment availability.
Please note that the code may not compile against X Server 1.20 since it no longer supports 24-bit color. [1]
The DDX compiles cleanly without compilation warnings on X Server 1.19.6.

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com

[1] https://gitlab.freedesktop.org/xorg/xserver/commit/0803918e64262482035f042e5e1f2a571d3dea1b

--
Adam Jackson (1):
      Remove #include "mibstore.h"

Kevin Brace (5):
      Remove miInitializeBackingStore
      Use const char for xf86GetOptValString return type
      Eliminate unused variable compilation warnings
      Use libpciaccess for newer X Servers when unmapping video RAM
      Version bumped to 1.3.0

Mihail Konev (1):
      autogen: add default patch prefix

git tag: xf86-video-apm-1.3.0
Comment 1 pete 2019-02-18 20:29:36 UTC
Created attachment 202140 [details]
build logs.

Builds without issue on my 12.0 AMD64 build server.  Here are the build logs from poudriere.
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-02-18 20:46:12 UTC
Would it be possible to improve the pkg-descr while here?

Actually, I'm wondering if we should drop this as it seems unlikely it is used:

https://bracecomputerlab.com/2019/02/06/xf86-video-apm-version-1-3-released/

but I guess it's harmless.
Comment 3 pete 2019-02-18 20:47:58 UTC
(In reply to pete from comment #1)
false alarm, i mistakenly built from the wrong github repo.  i'll be uploading a new patch and logfile as the previous patch needed some further updates to build correctly.
Comment 4 pete 2019-02-18 20:49:15 UTC
(In reply to pete from comment #3)
I agree that we can probably nuke this - but in the event we want to keep it around for a bit longer we'll have a working patch we can use.
Comment 5 pete 2019-02-18 20:51:38 UTC
Created attachment 202141 [details]
updated patch to fix issues with 1st attempt.

remove local patches which have been incorporated upstream in addition to version bump.
Comment 6 pete 2019-02-18 20:52:19 UTC
Created attachment 202142 [details]
poudriere build log

proper build logs for version 1.3.0
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-02-20 19:57:19 UTC
A commit references this bug:

Author: zeising
Date: Wed Feb 20 19:56:49 UTC 2019
New revision: 493437
URL: https://svnweb.freebsd.org/changeset/ports/493437

Log:
  x11-drivers/xf86-video-apm: Update to 1.3.0

  Update xf86-video-apm to 1.3.0.
  Remove patches that are incorporated upstream.
  This has not been run time tested due to lack of hardware.

  PR:		235839
  Submitted by:	pete@nomadlogic.org

Changes:
  head/x11-drivers/xf86-video-apm/Makefile
  head/x11-drivers/xf86-video-apm/distinfo
  head/x11-drivers/xf86-video-apm/files/
Comment 8 Niclas Zeising freebsd_committer freebsd_triage 2019-02-20 20:00:32 UTC
Committed, thanks!