Bug 235925 - audio/pulseaudio: Remove option for installing completions
Summary: audio/pulseaudio: Remove option for installing completions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-21 21:27 UTC by Romain Tartière
Modified: 2019-04-08 17:31 UTC (History)
0 users

See Also:
tobik: maintainer-feedback-

Attachments
Always install completions (2.71 KB, patch)
2019-02-21 21:27 UTC, Romain Tartière 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Tartière freebsd_committer freebsd_triage 2019-02-21 21:27:36 UTC 
Created attachment 202242 [details]
Always install completions

Hi!

The ports currently does not align with what the porter's handbook says:

> When available, completion files should always be installed. It is not
> necessary to make an option for it. If an option is used, though, always enable
> it in OPTIONS_DEFAULT.

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#shell-completion

The attached patch drops the BASH and ZSH options to unconditionally install completion files.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-08 17:31:59 UTC 
A commit references this bug:

Author: tobik
Date: Mon Apr  8 17:31:20 UTC 2019
New revision: 498395
URL: https://svnweb.freebsd.org/changeset/ports/498395

Log:
  audio/pulseaudio: Always install shell completions per Porter's Handbook

  PR:		235925
  Submitted by:	romain
  Approved by:	gnome (maintainer timeout, a month)

Changes:
  head/audio/pulseaudio/Makefile
  head/audio/pulseaudio/pkg-plist