Bug 235941 - www/cliqz: Update to 1.25.2
Summary: www/cliqz: Update to 1.25.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on: 236444
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-22 16:03 UTC by Santhosh Raju
Modified: 2019-03-13 17:51 UTC (History)
2 users (show)

See Also:

Attachments
Patch to upgrade the ports script to support cliqz-1.25.2 builds. (2.50 KB, patch)
2019-02-22 16:03 UTC, Santhosh Raju 		no flags Details | Diff
cliqz-1.25.2 update patch with plist fixes (2.85 KB, patch)
2019-02-22 20:00 UTC, Santhosh Raju 		no flags Details | Diff
cliqz-1.25.2 update patch with fixes for plist and symlink warning (3.34 KB, patch)
2019-02-24 13:32 UTC, Santhosh Raju 		no flags Details | Diff
cliqz-1.25.2 update patch with fixes for plist and symlink warning (3.34 KB, patch)
2019-03-07 03:56 UTC, Santhosh Raju 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Santhosh Raju 2019-02-22 16:03:02 UTC 
Created attachment 202267 [details]
Patch to upgrade the ports script to support cliqz-1.25.2 builds.

Cliqz has been updated from version 1.24.2 to 1.25.2.

I have made a patch that makes changes to the ports script to support building cliqz-1.25.2.

It would be nice if the patch can be applied to the ports tree of FreeBSD.

Thank you
Santhosh
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-02-22 19:16:15 UTC 
This has a plist issue:

Error: Orphaned: lib/cliqz/libmozwayland.so

and also a symlink issue:

Warning: Bad symlink '/usr/local/bin/cliqz' pointing to an absolute pathname '/usr/local/lib/cliqz/cliqz-bin'
Comment 2 Santhosh Raju 2019-02-22 20:00:23 UTC 
Created attachment 202270 [details]
cliqz-1.25.2 update patch with plist fixes

I have attached a new patch which fixes the missing plist update. Let me know if this works for you.

> Warning: Bad symlink '/usr/local/bin/cliqz' pointing to an absolute pathname '/usr/local/lib/cliqz/cliqz-bin'

Regarding the above it is done in post-install section.

${LN} -sf ${PREFIX}/lib/${PORTNAME}/${PORTNAME}-bin ${STAGEDIR}${PREFIX}/bin/${PORTNAME}

Do you have a suggestion on how to fix this?
Comment 3 Santhosh Raju 2019-02-24 13:32:52 UTC 
Created attachment 202327 [details]
cliqz-1.25.2 update patch with fixes for plist and symlink warning

I got a bit of time and went through the porters-handbook and replaced the absolute symbolic link reference with a relative symbolic link. 

https://www.freebsd.org/doc/en/books/porters-handbook/special.html

And this fixed the warning message.

I have updated the patch and obsoleted the two other patches.

Let me know if the issues have been fixed once you apply this patch.

Thank you.
Comment 4 Santhosh Raju 2019-03-05 09:22:47 UTC 
Hello

Any update on applying this patch to update www/cliqz?
Comment 5 Santhosh Raju 2019-03-07 03:56:42 UTC 
Created attachment 202668 [details]
cliqz-1.25.2 update patch with fixes for plist and symlink warning

Patch has been updated to consider the recent commits made in www/cliqz port.

Should no longer cause rejects when applying.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-03-07 04:08:35 UTC 
A commit references this bug:

Author: philip
Date: Thu Mar  7 04:08:13 UTC 2019
New revision: 494876
URL: https://svnweb.freebsd.org/changeset/ports/494876

Log:
  www/cliqz: Update to 1.25.2

  PR:		235941
  Submitted by:	Santhosh Raju <santhosh.raju@gmail.com> (maintainer)

Changes:
  head/www/cliqz/Makefile
  head/www/cliqz/distinfo
  head/www/cliqz/pkg-plist