Bug 236018 - graphics/libjxr: fix build with GCC-based architectures
Summary: graphics/libjxr: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-25 10:05 UTC by Piotr Kubaj
Modified: 2019-03-03 23:03 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd-2024)

Attachments
patch (2.43 KB, patch)
2019-02-25 10:05 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-02-25 10:05:52 UTC 
Created attachment 202346 [details]
patch

Base GCC doesn't support -Wno-extra-tokens, so remove this flag.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-03 23:01:03 UTC 
A commit references this bug:

Author: mi
Date: Sun Mar  3 23:00:40 UTC 2019
New revision: 494530
URL: https://svnweb.freebsd.org/changeset/ports/494530

Log:
  Fix handling of (some of) the warnings, by fixing them
  at the sources, rather than disabling them on command-line.

  The disabling was not working with gcc.

  PR:		236018
  Submitted by:	Piotr Kubaj

Changes:
  head/graphics/libjxr/Makefile
  head/graphics/libjxr/files/BSDmakefile.JxrDecApp
  head/graphics/libjxr/files/BSDmakefile.JxrEncApp
  head/graphics/libjxr/files/BSDmakefile.jxrgluelib
  head/graphics/libjxr/files/BSDmakefile.libjpegxr
  head/graphics/libjxr/files/patch-jxrlib_warnings
Comment 2 Mikhail Teterin freebsd_committer freebsd_triage 2019-03-03 23:02:58 UTC 
Thanks, Piotr, I committed your patch. However, there are some other warnings -- such having to do with shifting of negative numbers -- which might break subtly on those non-x86 platforms too...