Bug 236032 - www/gitlab-pages: Unbreak build with Go 1.12
Summary: www/gitlab-pages: Unbreak build with Go 1.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-25 16:39 UTC by Dmitri Goutnik
Modified: 2019-02-25 18:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
patch file (597 bytes, patch)
2019-02-25 16:39 UTC, Dmitri Goutnik 		dmgk: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-02-25 16:39:16 UTC 
Created attachment 202358 [details]
patch file

- Remove GOCACHE=off as build cache is required starting from Go 1.12 [1]
- While here,
  - pass MAKE_ENV (so GOCACHE defaults to $WRKDIR/.cache)
  - remove GO15VENDOREXPERIMENT=1 (default as of Go 1.6)

QA:
  poudriere testport: OK (112a, 112i, 120a)

[1] https://tip.golang.org/doc/go1.12#gocache
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-25 18:31:44 UTC 
A commit references this bug:

Author: swills
Date: Mon Feb 25 18:31:39 UTC 2019
New revision: 493887
URL: https://svnweb.freebsd.org/changeset/ports/493887

Log:
  www/gitlab-pages: Unbreak build with Go 1.12

  PR:		236032
  Submitted by:	Dmitri Goutnik <dg@syrec.org>

Changes:
  head/www/gitlab-pages/Makefile
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-02-25 18:33:55 UTC 
Committed, thanks!