Created attachment 202446 [details] git diff --no-prefix Paladin has version 2.0.0 available. Changes from version 1.1.0 include (besides under the hood stuff): - An -f command line flag that allows specifying a config file - A handle for the SIGINFO signal - Args to the children are passed as an array (so that it's possible to pass an argument with a space in it) - Fixes of some major bugs causing paladin to not correctly track the number of running children (so it wouldn't know when to exit), or not wait for children to exit before exiting itself after receiving SIGTERM. The updated source is at github.com/rwestlund/paladin, but I wasn't sure if I was supposed to attach a diff myself anyway, so I did.
Thanks for the PR! The ports tree only has the instructions for how to fetch and build each port; it doesn't vendor the code. So you need to attach a diff of the Makefile in the ports tree, not a diff of the source code. Here's what you need to do: - Check out the ports tree with svn. - Edit sysutils/paladin/Makefile to use the new version. - Update the checksum and use poudriere testport to make sure it builds and passes tests. - Use svn diff to make a patch and upload it here. There's a walkthrough in the Porter's Handbook, here: https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html Let me know if you have any questions :)
Oh, and because this update requires changes to the config file, make sure you add instructions to UPDATING: https://www.freebsd.org/doc/en/books/porters-handbook/moved-and-updating-files.html That file is touched a lot, so any diff you make may not apply by the time it gets committed. You can just write the text of it here and ask the committer to drop it in UPDATING when they commit it.
Created attachment 202469 [details] svn diff Here's the svn diff that shows the changes in the Makefile and distinfo. The other diff is a source code diff (I didn't read the handbook very carefully and didn't realize that wasn't what we needed).
That looks good, now you need the text for UPDATING. See comment #2.
Ah, forgot about that. How's this for an UPDATING entry (I assume the date should be the date it gets merged): AFFECTS: users of sysutils/paladin AUTHOR: Ryan Westlund <rlwestlund@gmail.com> The way paladin parses its config file has changed. The args parameter needs to be reformatted to an array of strings, rather than a single string separated by spaces.
Okay, you have my approval. Now you may need to find someone who can commit it so it doesn't sit for weeks. Try irc or the ports mailing list.
Committed, thanks!
A commit references this bug: Author: pi Date: Sat Mar 2 08:23:57 UTC 2019 New revision: 494373 URL: https://svnweb.freebsd.org/changeset/ports/494373 Log: sysutils/paladin: update 1.1.1 -> 2.0.0 - An -f command line flag that allows specifying a config file - A handle for the SIGINFO signal - Args to the children are passed as an array (so that it's possible to pass an argument with a space in it) - Fixes of some major bugs causing paladin to not correctly track the number of running children (so it wouldn't know when to exit), or not wait for children to exit before exiting itself after receiving SIGTERM. PR: 236111 Submitted by: rlwestlund@gmail.com Approved by: Randy Westlund <rwestlun@gmail.com> Changes: head/UPDATING head/sysutils/paladin/Makefile head/sysutils/paladin/distinfo