Bug 236166 - misc/xfce4-weather-plugin: Fix sunrise API
Summary: misc/xfce4-weather-plugin: Fix sunrise API
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL: https://bugzilla.xfce.org/show_bug.cg...
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2019-03-02 19:55 UTC by Olivier Duchateau
Modified: 2019-03-06 14:39 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+

Attachments
Fix sunrise API (27.54 KB, patch)
2019-03-02 19:55 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2019-03-02 19:55:42 UTC 
Created attachment 202510 [details]
Fix sunrise API

Currently, misc/xfce4-weather-plugin still uses the 1.1 sunrise API, but it has expired [1]. This patch updates to the latest API (2.0, see my comment on Xfce's Bugzilla [2] for details).

Manual intervention is required (through UPDATING or pkg-message). Users need to remove ~/.cache/xfce4/weather/ directory.

A commit in quarterly branch is needed too.

[1] https://api.met.no/weatherapi/sunrise/2.0/documentation
[2] https://bugzilla.xfce.org/show_bug.cgi?id=14972#c9
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-03-05 14:05:16 UTC 
I'm testing the patch.

Reading the comments on the XFCE bug, it looks like the manual intervention is not actually needed, am I correct?


Also, is this a security related issue? if not I don't think it is eligible for merging to quarterly. Anyway a new quarterly will be branched in a month at most.
Comment 2 Olivier Duchateau 2019-03-05 19:07:28 UTC 
(In reply to Guido Falsi from comment #1)

Yes, you are right, no manual intervention is required.

Merge into quarterly, is for deprecated 1.1 API. It is not security issue (avoid no response from met.no service).
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-03-06 10:52:50 UTC 
A commit references this bug:

Author: madpilot
Date: Wed Mar  6 10:52:15 UTC 2019
New revision: 494787
URL: https://svnweb.freebsd.org/changeset/ports/494787

Log:
  Import patch from upstream bug report for xfce4-weather-plugin to
  adapt to new upstream weather service API interface.

  Previous API version is deprecated and expired by upstream.

  While here, remove unneeded USES=intlhack.

  PR:		236166
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>
  Obtained from:	https://bugzilla.xfce.org/show_bug.cgi?id=14972
  MFH:		2019Q1

Changes:
  head/misc/xfce4-weather-plugin/Makefile
  head/misc/xfce4-weather-plugin/files/
  head/misc/xfce4-weather-plugin/files/patch-new_sunrise_API
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2019-03-06 10:55:05 UTC 
Committed. I unified the various patch file sin one patch, which seems more logical to me, since they're just one change actually.

Keeping bug open till I get a reply to MFH request.


Thanks for the patch!
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-03-06 11:45:43 UTC 
A commit references this bug:

Author: madpilot
Date: Wed Mar  6 11:45:30 UTC 2019
New revision: 494791
URL: https://svnweb.freebsd.org/changeset/ports/494791

Log:
  MFH: r494787

  Import patch from upstream bug report for xfce4-weather-plugin to
  adapt to new upstream weather service API interface.

  Previous API version is deprecated and expired by upstream.

  While here, remove unneeded USES=intlhack.

  PR:		236166
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>
  Obtained from:	https://bugzilla.xfce.org/show_bug.cgi?id=14972

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/misc/xfce4-weather-plugin/Makefile
  branches/2019Q1/misc/xfce4-weather-plugin/files/
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2019-03-06 14:39:31 UTC 
Merged too.