Created attachment 202530 [details] [patch] remove unnecessary localbase flags This is a low priority change, but I removed the global LDFLAGS and -I${LOCALBASE}/include from mutt/Makefile and built various combinations of options in poudriere. Attached is a patch to remove the global localbase flag settings.
(In reply to John Hein from comment #0) QA: poudriere (ok with many option combinations) portlint (ok - warning about unnecessary PORTREVISION unrelated to this PR, but could be removed)
Created attachment 202531 [details] [patch] fix non-default LOCALBASE for aspell Also attached is a patch to fix the aspell invocation if LOCALBASE != /usr/local. it just relies on PATH to find aspell rather than hard-coding the absolute path.
This seems alright however I think aspell should be using ${LOCALBASE}. Removing extra-patch-aspell and adding to the Make file ... pre-configure-ASPELL-on: ${ECHO_CMD} 'set ispell="${LOCALBASE}/bin/aspell --mode=email check"' >> \ ${WRKSRC}/doc/Muttrc.head ... If you think that's alright do you want to combine the patches and bump the PORTREVISION?
(In reply to Derek Schrock from comment #3) I generally prefer to not hard-code the path when possible. This let's the user have more control. It works fine for the default user since /usr/local/bin is in the PATH by default (and there's no ambiguity with a /usr/bin/aspell). And it allows someone who might want to use a different aspell the flexibility to do so (e.g., env PATH=/path/to/alt-aspell:$PATH mutt). I can definitely combine and bump. Give my feedback a think and let me know - my preference would be no hard-coded path, but it's your call as maintainer.
Ok. Leave the full path off.
Created attachment 203346 [details] Updated patch It seems that original poster is a little busy with RL or there is some sort of miscommunication, so I've updated the patch as per latest suggestions. Maintainer, can you please review it and approve if it looks ok: - Cleanup LDFLAGS, CONFIGURE_ENV [1] - Fix non-default LOCALBASE for aspell [1] [2] - Remove unused extra-patch-parent-child-match PR: 236189 Submitted by: John Hein <jcfyecrayz@liamekaens.com> [1] Approved by: Derek Schrock <dereks@lifeofadishwasher.com> (maintainer) [2]
Looks good. Thanks.
A commit references this bug: Author: ak Date: Thu Apr 4 04:07:18 UTC 2019 New revision: 497785 URL: https://svnweb.freebsd.org/changeset/ports/497785 Log: - Cleanup LDFLAGS, CONFIGURE_ENV [1] - Fix non-default LOCALBASE for aspell [1] - Remove unused extra-patch-parent-child-match PR: 236189 Submitted by: John Hein <jcfyecrayz@liamekaens.com> [1] Approved by: Derek Schrock <dereks@lifeofadishwasher.com> (maintainer) Changes: head/mail/mutt/Makefile head/mail/mutt/files/extra-patch-aspell head/mail/mutt/files/extra-patch-parent-child-match