Bug 236205 - graphics/goxel: fails to build with clang 8
Summary: graphics/goxel: fails to build with clang 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 236062
  Show dependency tree / graph
 
Reported: 2019-03-04 12:39 UTC by Jan Beich
Modified: 2019-03-07 20:57 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (val)

Attachments
goxel-werror.patch (390 bytes, patch)
2019-03-07 16:43 UTC, Val Packett 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-03-04 12:39:54 UTC 
$ poudriere jail -cj clang8 -v projects/clang800-import -m svn+https
$ poudriere testport -j clang8 graphics/goxel
[...]
ext_src/lua/lundump.c:237:33: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
  checkliteral(S, LUA_SIGNATURE + 1, "not a");  /* 1st char already checked */
                  ~~~~~~~~~~~~~~^~~
ext_src/lua/lundump.c:237:33: note: use array indexing to silence this warning
  checkliteral(S, LUA_SIGNATURE + 1, "not a");  /* 1st char already checked */
                                ^
                  &             [  ]
1 error generated.

http://package18.nyi.freebsd.org/data/headamd64PR236062-default/2019-03-01_06h42m53s/logs/errors/goxel-0.8.2.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-03-04 23:31:10 UTC 
Reminder: Clang 8 was merged to 13.0-CURRENT in base r344779. Maintainers, expect pkg-fallout@ mail soon.
Comment 2 Val Packett 2019-03-07 16:43:01 UTC 
Created attachment 202691 [details]
goxel-werror.patch

damn Werror. let's disable it
Comment 3 Walter Schwarzenfeld 2019-03-07 19:51:59 UTC 
compiler suggests
checkliteral(S, &LUA_SIGNATURE [+ 1], "not a"); 

but it is only wanted to skip the first char, the simpelst is

checkliteral(S, LUA_SIGNATURE [1], "not a");
Comment 4 Walter Schwarzenfeld 2019-03-07 20:07:37 UTC 
this => checkliteral(S, LUA_SIGNATURE [1], "not a"); does not work.

(I wanted to cancel comment3, but it was saved....).
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-03-07 20:57:09 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Mar  7 20:56:48 UTC 2019
New revision: 495000
URL: https://svnweb.freebsd.org/changeset/ports/495000

Log:
  graphics/goxel: unbreak with clang 8

  PR:		236205
  Submitted by:	Greg V (maintainer)

Changes:
  head/graphics/goxel/Makefile