Bug 236338 - databases/py-pglast: Update to 1.2
Summary: databases/py-pglast: Update to 1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kai Knoblich
URL: https://reviews.freebsd.org/D19522
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-06 21:02 UTC by Jaroslaw Zurek
Modified: 2019-03-09 18:25 UTC (History)
3 users (show)

See Also:

Attachments
svn diff (793 bytes, patch)
2019-03-06 21:02 UTC, Jaroslaw Zurek 		a.wolk: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslaw Zurek 2019-03-06 21:02:07 UTC 
Created attachment 202663 [details]
svn diff

I am attaching the new update of py-pglast port. Discussed with MAINTAINER in person. This is my first port for FreeBSD. Feel free to ping me if anything is wrong. No new files in the port -- just a trivial bump.
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2019-03-09 14:32:51 UTC 
Hello Jaroslaw,

thank you for the patch. It builds fine so far and it's nearly ready to commit. 

There's one small hurdle at the moment: You already wrote that you've discussed it with the maintainer in person and I can see by the email addresses that you both are co-workers.

I just need a short approval from the maintainer by setting the maintainer-approval flag to "+" on the patch file to proceed and speed things up.
Comment 2 Adam Wolk 2019-03-09 16:59:23 UTC 
Hi Kai,

thanks for getting in touch and taking care of this.

I do approve the patch, how do I set the flag on the diff? I don't seem to have permission to edit anything in this ticket.
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2019-03-09 18:12:08 UTC 
(In reply to Adam Wolk from comment #2)

Hi Adam,

thank you for the quick response and the approval. Hm, usually you can set the approval flag by clicking on "Details" in the "Attachments" section and then set the flag accordingly.

Anyway, your approval in your response should be enough so I'm going to commit the patch in some minutes.
Comment 4 Adam Wolk 2019-03-09 18:20:57 UTC 
Comment on attachment 202663 [details]
svn diff

lgtm.
Comment 5 Adam Wolk 2019-03-09 18:21:32 UTC 
Thanks for the pointer, think I found it ;)
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-03-09 18:23:54 UTC 
A commit references this bug:

Author: kai
Date: Sat Mar  9 18:23:46 UTC 2019
New revision: 495187
URL: https://svnweb.freebsd.org/changeset/ports/495187

Log:
  databases/py-pglast: Update to 1.2

  Changelog:

  * Implement new split() function
  * Implement BooleanTest printer

  https://github.com/lelit/pglast/blob/v1.2/CHANGES.rst

  PR:		236338
  Submitted by:	Jaroslaw Zurek <j.zurek@fudosecurity.com>
  Approved by:	tcberner (mentor), maintainer
  Differential Revision:	https://reviews.freebsd.org/D19522

Changes:
  head/databases/py-pglast/Makefile
  head/databases/py-pglast/distinfo
Comment 7 Kai Knoblich freebsd_committer freebsd_triage 2019-03-09 18:25:15 UTC 
Committed, thank you both for the patch and the quick approval! ;)