Bug 236416 - audio/audacity: Update to 2.3.1
Summary: audio/audacity: Update to 2.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL: https://wiki.audacityteam.org/wiki/Re...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-09 10:50 UTC by Jack
Modified: 2019-03-10 04:30 UTC (History)
0 users

See Also:

Attachments
patch to upgrade audacity to 2.3.1 (6.71 KB, text/plain)
2019-03-09 10:50 UTC, Jack 		no flags Details
audacity.diff (5.31 KB, patch)
2019-03-09 12:59 UTC, Tobias Kortkamp 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2019-03-09 10:50:38 UTC 
Created attachment 202735 [details]
patch to upgrade audacity to 2.3.1

Upgrade audio/audacity to 2.3.1
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-09 11:41:37 UTC 
Why does Audacity need Fortran now?
Comment 2 Jack 2019-03-09 11:49:23 UTC 
Related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220822 in which linking with libatomic isn't working with clang so adding uses fortran gives the right ldflags like in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232546
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-09 12:59:37 UTC 
Created attachment 202744 [details]
audacity.diff

So upstream added [1] for Linux without any explanation and now it
needs libatomic everywhere clang is used.  It builds fine without
USES=fortran if I just revert that.  Tested on 11.2/amd64, 12.0/i386.

[1] https://github.com/audacity/audacity/commit/43402438f8fa457839e14153dcfcae1fa2ca8feb
Comment 4 Jack 2019-03-09 13:05:16 UTC 
I guess we should ask upstream why atomic is needed if we're using clang.
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-09 13:07:49 UTC 
Please do.
Comment 6 Jack 2019-03-10 03:41:52 UTC 
Just emailed upstream and tested without the -latomic flag. Appears to compile and run fine so let's go with that until they release a new version. Unlikely they will revert the change in an already released version.
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-10 04:30:03 UTC 
Committed. Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-03-10 04:30:11 UTC 
A commit references this bug:

Author: tobik
Date: Sun Mar 10 04:29:42 UTC 2019
New revision: 495224
URL: https://svnweb.freebsd.org/changeset/ports/495224

Log:
  audio/audacity: Update to 2.3.1

  Changes:	https://wiki.audacityteam.org/wiki/Release_Notes_2.3.1
  PR:		236416
  Submitted by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile
  head/audio/audacity/distinfo
  head/audio/audacity/files/patch-configure.ac
  head/audio/audacity/files/patch-src_MemoryX.h
  head/audio/audacity/pkg-plist