Bug 236542 - devel/llvm80: rc5 build fails to patch without EXTRAS
Summary: devel/llvm80: rc5 build fails to patch without EXTRAS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-15 04:47 UTC by Laurence 'GreenReaper' Parry
Modified: 2019-03-20 23:01 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)

Attachments
Failed build log without EXTRAS (2.70 KB, text/plain)
2019-03-15 04:47 UTC, Laurence 'GreenReaper' Parry 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurence 'GreenReaper' Parry 2019-03-15 04:47:49 UTC 
Created attachment 202871 [details]
Failed build log without EXTRAS

I configured llvm80-8.0.0.r5 to build only the following:
CLANG - GOLD - LLD - OPENMP
with the BE_NATIVE option.

On attempting to build via portinstall, it attempted to patch the following files, which did not exist because they are extra tools, causing the make to fail:
tools/clang/tools/extra/clang-tidy/tool/clang-tidy-diff.py
tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py
tools/clang/tools/extra/include-fixer/find-all-symbols/tool/run-find-all-symbols.py

Adding EXTRAS allows the patching and configuration phases to complete.

The files mentioned are included within the Makefile twice, once in the initial SHEBANG_FILES and then again in the section guarded by:
.if ${PORT_OPTIONS:MCLANG}

However removing the three files from the first SHEBANG_FILES causes the build to subsequently prompt for a patch. Only after moving ths file:
patch-tools_clang_tools_extra_clang-doc_tool_CMakeLists.txt

...from the files directory will the build then proceed past patching and configuration and begin to build without EXTRAS.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-20 20:20:05 UTC 
A commit references this bug:

Author: brooks
Date: Wed Mar 20 20:19:04 UTC 2019
New revision: 496386
URL: https://svnweb.freebsd.org/changeset/ports/496386

Log:
  Update to 8.0.0 Release.

  Fix build with EXTRAS disabled.

  PR:		236542
  Submitted by:	greenreaper@hotmail.com
  Sponsored by:	DARPA, AFRL

Changes:
  head/devel/llvm80/Makefile
  head/devel/llvm80/distinfo
  head/devel/llvm80/files/extras/
  head/devel/llvm80/files/extras/patch-tools_clang_tools_extra_clang-doc_tool_CMakeLists.txt
  head/devel/llvm80/files/patch-tools_clang_tools_extra_clang-doc_tool_CMakeLists.txt
Comment 2 Brooks Davis freebsd_committer freebsd_triage 2019-03-20 23:01:16 UTC 
Thank you for the report.