Created attachment 203076 [details] diff file I'd like to add these two ports to the tree
Hi, I review the ports you submit and did some small changes to make it work as expect and comply with the ports rules : - new ports should be submitted as shar files, not diff files - The Makefile first line should should be '# ${FreeBSD}' - The COMMENT first character should be capitalized - The URL in the pkg-descr file should be preceded by 'WWW: ' You can learn more about the porting techniques by reading the FreeBSD porter handbook. (https://www.freebsd.org/doc/en/books/porters-handbook/) Also before submitting a port you can use the linter (ports-mgmt/portlint) to validate your ports files, and poudriere to ensure everything work as expected. Here are the modified versions of your ports: - https://people.freebsd.org/~rodrigo/php-lz4-0.3.5.shar - https://people.freebsd.org/~rodrigo/php-zstd-0.5.0.shar Feel free to ask if you have any question or remark regarding the changes I done. And when you think your ports are fine, and can be committed, I will do it for you. Happy hacking, - rodrigo
(In reply to Rodrigo Osorio from comment #1) Looks good. Thanks.
A commit references this bug: Author: rodrigo Date: Tue Apr 2 22:00:56 UTC 2019 New revision: 497595 URL: https://svnweb.freebsd.org/changeset/ports/497595 Log: Add two new ports archivers/php-zstd and archivers/php-lz4 php-zstd is a PHP extension for zstd compresssion algorithm https://github.com/kjdev/php-ext-zstd php-lz4 is a PHP extension for the lz4 compression algorithm https://github.com/kjdev/php-ext-lz4 PR: 236742 Submitted by: Paavo-Einari Kaipila <pkaipila@gmail.com> Changes: head/archivers/Makefile head/archivers/php-lz4/ head/archivers/php-lz4/Makefile head/archivers/php-lz4/distinfo head/archivers/php-lz4/pkg-descr head/archivers/php-zstd/ head/archivers/php-zstd/Makefile head/archivers/php-zstd/distinfo head/archivers/php-zstd/pkg-descr
Committed, thanks.