Bug 236878 - ftp/curl: Curl started conflicting with fish shell
Summary: ftp/curl: Curl started conflicting with fish shell
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-29 12:17 UTC by László Károlyi
Modified: 2019-03-29 18:21 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description László Károlyi 2019-03-29 12:17:11 UTC 
Hey,

the latest curl package started conflicting with the fish shell package.

Here's the error message it provides on trying to install both:

  - fish-3.0.2 conflicts with curl-7.64.1 on /usr/local/share/fish/completions/curl.fish

Please fix it.

Cheers,
László
Comment 1 Alan Somers freebsd_committer freebsd_triage 2019-03-29 14:05:26 UTC 
So the curl.fish file shipped by the current shells/fish port is a mere one line.  It's clearly inferior to the curl.fish file shipped by ftp/curl.  BUT the curl.fish file in fish's repository is far better.  It was derived from curl's curl.fish file, but has better descriptions for each option.  So in the short term we should keep curl's curl.fish file, but in the long term we should keep fish's.  I'm of the opinion that it would be simpler and easier just to keep fish's even for current releases.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-03-29 16:34:07 UTC 
(In reply to Alan Somers from comment #1)

The current curl.fish from fish 3.0.2 is not ideal but the one from fish-shell repository is better. I would like to remove curl.fish from ftp/curl.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-03-29 16:34:55 UTC 
A commit references this bug:

Author: sunpoet
Date: Fri Mar 29 16:34:35 UTC 2019
New revision: 497165
URL: https://svnweb.freebsd.org/changeset/ports/497165

Log:
  Do not install curl.fish to avoid conflicts with shells/fish

  - Bump PORTREVISION for package change

  PR:		236878
  Reported by:	Laszlo Karolyi <laszlo@karolyi.hu>

Changes:
  head/ftp/curl/Makefile
  head/ftp/curl/files/patch-scripts-Makefile.in
  head/ftp/curl/pkg-plist
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-03-29 16:34:56 UTC 
Committed. Thanks!
Comment 5 László Károlyi 2019-03-29 18:21:02 UTC 
Thanks for the fast reaction. I just tested it, it no longer conflicts.