While preparing for Boost upgrade this port failed to build. Can you help to avoid marking it as BROKEN? $ fetch -qo- 'https://reviews.freebsd.org/D19303?download=true' | patch -Efsp0 -d /usr/ports $ make all deinstall install clean -C/usr/ports/devel/boost-jam $ make all deinstall install clean -C/usr/ports/devel/boost-libs $ make -C/usr/ports/security/botan2 [...] src/cli/tls_proxy.cpp:373:31: error: no member named 'get_io_service' in 'boost::asio::basic_socket_acceptor<boost::asio::ip::tcp, boost::asio::executor>' m_acceptor.get_io_service(), ~~~~~~~~~~ ^ src/cli/tls_http_server.cpp:438:31: error: no member named 'get_io_service' in 'boost::asio::basic_socket_acceptor<boost::asio::ip::tcp, boost::asio::executor>' m_acceptor.get_io_service(), ~~~~~~~~~~ ^
Hi Jan, I'm looking into other ports with a similar error. Hopefully I can "steal" the fix and implement it for botan. If I get it to compile and work I will create a PR on github to also fix it upstream. To be continued...
Created attachment 203467 [details] Update to Botan 2.10.0, include fix for boost 1.70 compat. This patch updates Botan to 2.10.0, which includes a fix for PR #236450 . I also added a patch to fix compatibility with boost 1.70. While here also added a SHLIBVER variable to the Makefile to help reduce changes to pkg-plist. Poudriere buildlog: https://pkg.cainites.net/data/freebsd_12x64-boost-botan-boost-botan/2019-04-08_09h58m55s/logs/botan2-2.10.0.log
(In reply to Ralf van der Enden from comment #2) > While here also added a SHLIBVER variable to the Makefile > to help reduce changes to pkg-plist. Not a good idea as it makes it non-obvious when to bump PORTREVISION of consumers due to SONAME or ABI changes. https://abi-laboratory.pro/tracker/timeline/botan/
Nevermind. This port requires bumping consumers on pretty much each update, anyway.
Hi Jan, Every new version indeed bumps the SHLIBVER. On a side note... this PR makes #236450 obsolete.
A commit references this bug: Author: jbeich Date: Mon Apr 8 11:51:15 UTC 2019 New revision: 498365 URL: https://svnweb.freebsd.org/changeset/ports/498365 Log: security/botan2: unbreak with boost 1.70 PR: 237019 Submitted by: Ralf van der Enden Obtained from: upstream Changes: head/security/botan2/files/ head/security/botan2/files/patch-boost-1.70
A commit references this bug: Author: jbeich Date: Mon Apr 8 11:51:23 UTC 2019 New revision: 498366 URL: https://svnweb.freebsd.org/changeset/ports/498366 Log: security/botan2: reduce SOVERSION churn ABI isn't compatible between minor updates, so SONAME changes very frequently which requires rebuilding consumers. PR: 237019 Submitted by: Ralf van der Enden (maintainer) Changes: head/security/botan2/Makefile head/security/botan2/pkg-plist
A commit references this bug: Author: jbeich Date: Mon Apr 8 11:51:33 UTC 2019 New revision: 498367 URL: https://svnweb.freebsd.org/changeset/ports/498367 Log: security/botan2: update to 2.10.0 PR: 236450 237019 Submitted by: Ralf van der Enden (maintainer) Changes: head/dns/powerdns/Makefile head/dns/powerdns-recursor/Makefile head/editors/encryptpad/Makefile head/security/botan2/Makefile head/security/botan2/distinfo
MARKED AS SPAM