Bug 237117 - x11/pcdm: fix build with GCC-based architectures
Summary: x11/pcdm: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-08 18:24 UTC by Piotr Kubaj
Modified: 2019-05-05 18:03 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (jt)

Attachments
patch (391 bytes, patch)
2019-04-08 18:24 UTC, Piotr Kubaj 		no flags Details | Diff
Improved patch (1.05 KB, patch)
2019-04-11 18:47 UTC, Fernando Apesteguía 		fernape: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-08 18:24:04 UTC 
Created attachment 203500 [details]
patch

This port needs USES=compiler:c++11-lang to build on GCC architectures.

Tested on powerpc64 and amd64.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2019-04-11 18:47:58 UTC 
Created attachment 203603 [details]
Improved patch

I added a few additional changes:

* Reorder USE in the Makefile
* Add widgets as a USE_QT member
* Add USE_GL and USE_XORG (suggested by the framework)
* Fix wrong %%ETCDIR%% substitution in pkg-plist

Notice this port fails in poudriere at the pkg uninstall test since the pkg-install script installs a pcdm.conf file in etc/ that is not deleted on uninstall, but I think we're OK.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2019-04-20 16:21:48 UTC 
Committed,

Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2019-04-22 16:51:33 UTC 
Closed this one by mistake.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2019-04-23 20:29:03 UTC 
Returning to the pool now that Piotr is a committer.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2019-04-24 02:09:03 UTC 
Submitter is now committer.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-05-05 18:00:44 UTC 
A commit references this bug:

Author: pkubaj
Date: Sun May  5 18:00:13 UTC 2019
New revision: 500868
URL: https://svnweb.freebsd.org/changeset/ports/500868

Log:
  x11/pcdm: fix build with GCC-based architectures

  This port needs USES=compiler:c++11-lang to build on GCC architectures.

  Additionally (by fernape):
  * Reorder USE in the Makefile
  * Add widgets as a USE_QT member
  * Add USE_GL and USE_XORG (suggested by the framework)
  * Fix wrong %%ETCDIR%% substitution in pkg-plist

  PR:		237117
  Approved by:	linimon (mentor)

Changes:
  head/x11/pcdm/Makefile
  head/x11/pcdm/pkg-plist