Bug 237406 - net-p2p/retroshare: Fails to build with upnp 1.8.x
Summary: net-p2p/retroshare: Fails to build with upnp 1.8.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://people.freebsd.org/~tobik/log...
Keywords:
Depends on:
Blocks: 234669
  Show dependency tree / graph
 
Reported: 2019-04-20 09:08 UTC by Tobias Kortkamp
Modified: 2019-04-22 08:28 UTC (History)
1 user (show)

See Also:
peter: maintainer-feedback+

Attachments
retroshare.diff (3.77 KB, patch)
2019-04-20 14:54 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (peter)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-20 09:08:44 UTC 
Can you help fix it?

In file included from rsserver/rsinit.cc:779:
In file included from ./upnp/upnphandler_linux.h:13:
./upnp/UPnPBase.h:35:10: fatal error: 'upnp/upnpdebug.h' file not found
#include <upnp/upnpdebug.h>
         ^~~~~~~~~~~~~~~~~~
11 warnings and 1 error generated.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-20 14:54:13 UTC 
Created attachment 203830 [details]
retroshare.diff

One possible solution/workaround proposed in the upstream issue is
to switch to miniupnpc.  Here's a patch to do that.
Comment 2 peter 2019-04-22 07:23:27 UTC 
Looks good to me.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-22 08:27:54 UTC 
A commit references this bug:

Author: tobik
Date: Mon Apr 22 08:27:00 UTC 2019
New revision: 499614
URL: https://svnweb.freebsd.org/changeset/ports/499614

Log:
  net-p2p/retroshare: Switch from devel/upnp to net/miniupnpc

  RetroShare does not build with upnp >= 1.8.  Upstream does not have
  a solution for this yet other than suggesting to switch to using
  miniupnpc as a workaround.

  PR:		237406
  Submitted by:	tobik
  Approved by:	peter@netkey.at (maintainer)

Changes:
  head/net-p2p/retroshare/Makefile
  head/net-p2p/retroshare/files/patch-libretroshare_src_libretroshare.pro
  head/net-p2p/retroshare/files/patch-retroshare-gui_src_retroshare-gui.pro
  head/net-p2p/retroshare/files/patch-retroshare-nogui_src_retroshare-nogui.pro
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-22 08:28:11 UTC 
Committed. Thanks!