Bug 237499 - net/p5-MaxMind-DB-Reader-XS: respect ${CC}
Summary: net/p5-MaxMind-DB-Reader-XS: respect ${CC}
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-23 16:25 UTC by Piotr Kubaj
Modified: 2019-04-24 17:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (341 bytes, patch)
2019-04-23 16:25 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (sunpoet)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-23 16:25:30 UTC 
Created attachment 203932 [details]
patch

net/p5-MaxMind-DB-Reader-XS doesn't respect ${CC} and uses base GCC on GCC architectures.

Add CONFIGURE_ENV+=CC=${CC} to respect it and fix build.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-23 17:54:49 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Apr 23 17:53:38 UTC 2019
New revision: 499785
URL: https://svnweb.freebsd.org/changeset/ports/499785

Log:
  Fix build on powerpc

  - Respect CC

  PR:		237499
  Submitted by:	pkubaj

Changes:
  head/net/p5-MaxMind-DB-Reader-XS/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-04-23 17:56:39 UTC 
Committed. Thanks!
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-23 18:42:17 UTC 
You committed CONFIGURE_ENV= (not +=), which overwrites existing CONFIGURE_ENV.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-04-24 16:18:53 UTC 
There is no existing CONFIGURE_ENV before that line. CONFIGURE_ENV entries are added by framework after ".include <bsd.port.mk>". Please check again the result of "make -V CONFIGURE_ENV" with/without +.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-04-24 16:21:04 UTC 
(In reply to Piotr Kubaj from comment #3)

Do you have CONFIGURE_ENV settings in /etc/make.conf?
Comment 6 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-24 17:28:03 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #4)
Ah, you're right. I assumed that the existing CONFIGURE_ENV (set from Mk) will be overwritten, but that is not the case. Sorry for the noise.