Bug 237506 - devel/thrift-cpp: fix build with GCC-based architectures
Summary: devel/thrift-cpp: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-23 19:39 UTC by Piotr Kubaj
Modified: 2019-05-20 16:42 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (komarov)

Attachments
patch (960 bytes, patch)
2019-04-23 19:39 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (komarov)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-23 19:39:48 UTC 
Created attachment 203942 [details]
patch

Add -L${OPENSSLLIB} -I${OPENSSLINC} only when base OpenSSL isn't used. Explicitly adding -L/usr/lib make ports GCC link to libstdc++ from /usr/lib instead of /usr/local/lib/gcc8.

Also, explicitly don't use Lua and Qt5, the port uses it if it's installed.

Tested on powerpc64 and amd64.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-05-20 16:42:25 UTC 
A commit references this bug:

Author: pkubaj
Date: Mon May 20 16:42:00 UTC 2019
New revision: 502124
URL: https://svnweb.freebsd.org/changeset/ports/502124

Log:
  devel/thrift-cpp: fix build with GCC-based architectures

  Add -L${OPENSSLLIB} -I${OPENSSLINC} only when base OpenSSL isn't used. Explicitly adding -L/usr/lib make ports GCC link to libstdc++ from /usr/lib instead of /usr/local/lib/gcc8.
  Also, explicitly don't use Lua and Qt5, the port uses it if it's installed.

  PR:		237506
  Approved by:	komarov@valerka.net (maintainer timeout), mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20287

Changes:
  head/devel/thrift-cpp/Makefile