Bug 237558 - net/ocserv: fix build with GCC-based architectures
Summary: net/ocserv: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-04-25 15:08 UTC by Piotr Kubaj
Modified: 2019-04-26 19:00 UTC (History)
1 user (show)

See Also:
cpm: maintainer-feedback+

Attachments
patch (788 bytes, patch)
2019-04-25 15:08 UTC, Piotr Kubaj 		cpm: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-25 15:08:58 UTC 
Created attachment 204008 [details]
patch

Remove -Wno-implicit-fallthrough from configure.ac. This flag is not supported by base GCC and the port still builds without it with Clang.

Tested on powerpc64 and amd64.
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-04-26 11:40:15 UTC 
Approved!

Please, go ahead and push the commit :)

Thanks, Piotr.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-26 16:15:19 UTC 
A commit references this bug:

Author: pkubaj
Date: Fri Apr 26 16:14:45 UTC 2019
New revision: 500117
URL: https://svnweb.freebsd.org/changeset/ports/500117

Log:
  net/ocserv: fix build with base GCC

  -Wno-implicit-fallthrough is not supported by GCC 4.2

  PR:		237558
  Approved by:	tcberner (mentor), cpm (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D20075

Changes:
  head/net/ocserv/files/patch-configure.ac
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-26 19:00:15 UTC 
Committed, thanks!