Bug 237646 - sysutils/vm-bhyve: "vm init" should give a warning if kern.init_shutdown_timeout or rcshutdown_timeout are too low
Summary: sysutils/vm-bhyve: "vm init" should give a warning if kern.init_shutdown_time...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL:
Keywords: bhyve, feature
Depends on:
Blocks:
 
Reported: 2019-04-29 15:24 UTC by Victor Sudakov
Modified: 2025-03-19 13:28 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (churchers)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2019-04-29 15:24:10 UTC
I think "vm init" should give a warning if the sysctl kern.init_shutdown_timeout is set to the default value of 120 seconds, or if rcshutdown_timeout is defined and too short.

CBSD offers to reassign these settings during the initialization process (as well as rcshutdown_timeout): https://github.com/cbsd/cbsd/issues/374 I

I think the default kern.init_shutdown_timeout=120s is too short for the graceful shutdown of all VMs, but this shortage is very poorly documented.

Or perhaps it's worth mentioning in the pkg-message.
Comment 1 purk 2019-04-29 20:41:04 UTC
(In reply to Victor Sudakov from comment #0)

Remember: bugs.freebsd.org is a task tracker for the FreeBSD project. vm-bhyve is a third-party software that is not part of FreeBSD and not supported by FreeBSD developers. Please use the appropriate resource for vm-bhyve feature request: 
https://github.com/churchers/vm-bhyve/issues. This is not a FreeBSD bug.
Comment 2 Victor Sudakov 2019-04-30 01:32:45 UTC
(In reply to purk from comment #1)
Reported upstream: https://github.com/churchers/vm-bhyve/issues/303

> This is not a FreeBSD bug.

A pkg-message could be useful IMHO.
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2025-02-26 09:47:35 UTC
Good Idea indeed! I'll fix this
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-03-19 13:27:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=667b6029a21821883483beb71882c521f5177bd4

commit 667b6029a21821883483beb71882c521f5177bd4
Author:     Dries Michiels <driesm@FreeBSD.org>
AuthorDate: 2025-03-19 13:25:09 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2025-03-19 13:26:18 +0000

    sysutils/vm-bhyve(-devel): add note to increase shutdown timers

    PR:     237646

 sysutils/vm-bhyve-devel/pkg-message | 5 +++++
 sysutils/vm-bhyve/pkg-message       | 5 +++++
 2 files changed, 10 insertions(+)
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2025-03-19 13:28:27 UTC
Committed!