Bug 237868 - biology/jellyfish: fix build with GCC-based architectures
Summary: biology/jellyfish: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason W. Bacon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-13 07:54 UTC by Piotr Kubaj
Modified: 2019-05-13 16:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jwb)

Attachments
patch (4.77 KB, patch)
2019-05-13 07:54 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (jwb)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-05-13 07:54:57 UTC 
Created attachment 204348 [details]
patch

Add -faligned-new for support for alignment parameter in new when using GCC:
sub_commands/count_main.cc:285:71: note: uses 'void* operator new(std::size_t)', which does not have an alignment parameter
sub_commands/count_main.cc:285:71: note: use '-faligned-new' to enable C++17 over-aligned new support

Replace couple of exceptions from using value to references:
sub_commands/count_main.cc:333:28: error: catching polymorphic type 'class MergeError' by value [-Werror=catch-value=]
         } catch(MergeError e) {
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2019-05-13 08:03:18 UTC 
Upstream PR at https://github.com/gmarcais/Jellyfish/pull/142
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2019-05-13 14:57:59 UTC 
There is a new release, 2.2.10.

Work-in-progress upgrade including your patches here:

https://github.com/outpaddling/freebsd-ports-wip/tree/master/jellyfish

Thanks,

   JB
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-05-13 16:23:55 UTC 
A commit references this bug:

Author: jwb
Date: Mon May 13 16:23:37 UTC 2019
New revision: 501578
URL: https://svnweb.freebsd.org/changeset/ports/501578

Log:
  biology/jellyfish: Upgrade to 2.2.10, patch for powerpc64

  PR:             237868
  Submitted by:   pkubaj

Changes:
  head/biology/jellyfish/Makefile
  head/biology/jellyfish/distinfo
  head/biology/jellyfish/files/patch-include_jellyfish_file__header.hpp
  head/biology/jellyfish/files/patch-include_jellyfish_hash__counter.hpp
  head/biology/jellyfish/files/patch-sub__commands_count__main.cc
  head/biology/jellyfish/files/patch-sub__commands_merge__main.cc
  head/biology/jellyfish/files/patch-sub__commands_query__main.cc
  head/biology/jellyfish/pkg-plist
Comment 4 Jason W. Bacon freebsd_committer freebsd_triage 2019-05-13 16:25:15 UTC 
Upgraded to 2.2.10, applied slightly modified patches.

Thanks!