Bug 237877 - sysutils/py-google-compute-engine: disable boto to avoid breakage when running with python3
Summary: sysutils/py-google-compute-engine: disable boto to avoid breakage when runnin...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-13 12:32 UTC by Lucas Kanashiro
Modified: 2019-05-25 21:45 UTC (History)
0 users

See Also:

Attachments
disable boto (1016 bytes, patch)
2019-05-13 12:32 UTC, Lucas Kanashiro 		no flags Details | Diff
disable boto (1.43 KB, patch)
2019-05-13 18:23 UTC, Lucas Kanashiro 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Kanashiro 2019-05-13 12:32:06 UTC 
Created attachment 204356 [details]
disable boto

As I mentioned here [1], google-cloud-sdk does not support python3 yet, and when py-google-compute-engine runs with python3 and tries to call the sdk (under some circumstances the agent can call it via boto) we get an error. Since boto is not a core/mandatory dependency of the agent I am submitting this patch to disable boto and avoid python3 issues.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237872
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-05-13 14:20:20 UTC 
Should this line be removed?:

 15 RUN_DEPENDS=    ${PYTHON_PKGNAMEPREFIX}boto>0:devel/py-boto@${PY_FLAVOR} \
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-05-13 14:21:20 UTC 
Oh, it looks like google-cloud-sdk kinda supports python3:

https://cloud.google.com/sdk/install

Note: As of Cloud SDK version 206.0.0, the gcloud CLI has experimental support for running using a Python 3.4+ interpreter (run gcloud topic startup for exclusions and more information on configuring your Python interpreter). All other Cloud SDK tools still require a Python 2.7 interpreter.

Not sure what to make of that in terms of packaging.
Comment 3 Lucas Kanashiro 2019-05-13 18:23:15 UTC 
Created attachment 204363 [details]
disable boto

Do not run time depend on boto
Comment 4 Lucas Kanashiro 2019-05-13 18:30:37 UTC 
(In reply to Steve Wills from comment #2)
This is new for me. Since this is an experimental support I'd like to keep boto disabled until we get a stable python 3 support. We are using this approach in other operating system.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-05-13 18:32:41 UTC 
A commit references this bug:

Author: swills
Date: Mon May 13 18:32:13 UTC 2019
New revision: 501581
URL: https://svnweb.freebsd.org/changeset/ports/501581

Log:
  sysutils/py-google-compute-engine: disable boto

  This avoids breakage when running with python3

  PR:		237877
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer)
  MFH:		2019Q2

Changes:
  head/sysutils/py-google-compute-engine/Makefile
  head/sysutils/py-google-compute-engine/files/instance_configs.cfg.distro.sample
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-05-13 18:33:43 UTC 
A commit references this bug:

Author: swills
Date: Mon May 13 18:33:00 UTC 2019
New revision: 501582
URL: https://svnweb.freebsd.org/changeset/ports/501582

Log:
  MFH: r501581

  sysutils/py-google-compute-engine: disable boto

  This avoids breakage when running with python3

  PR:		237877
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer)

  Approved by:	ports-secteam (implicit, bug fix)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/sysutils/py-google-compute-engine/Makefile
  branches/2019Q2/sysutils/py-google-compute-engine/files/instance_configs.cfg.distro.sample
Comment 7 Steve Wills freebsd_committer freebsd_triage 2019-05-13 18:34:32 UTC 
Committed, thanks!