Bug 238066 - graphics/ipe: fix build with GCC-based architectures
Summary: graphics/ipe: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-23 07:30 UTC by Piotr Kubaj
Modified: 2019-06-11 18:50 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
patch (558 bytes, patch)
2019-05-23 07:30 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (bofh)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-05-23 07:30:34 UTC 
Created attachment 204561 [details]
patch

Add include limits.h to ipelib/ipeplatform.cpp to find PATH_MAX:
ipeplatform.cpp: In static member function 'static ipe::String ipe::Platform::realPath(ipe::String)':
ipeplatform.cpp:420:14: error: 'PATH_MAX' was not declared in this scope
   char rpath[PATH_MAX];
              ^~~~~~~~
ipeplatform.cpp:420:14: note: suggested alternative: 'INT8_MAX'
   char rpath[PATH_MAX];
              ^~~~~~~~
              INT8_MAX
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-05-29 21:25:01 UTC 
This builds for me, so once the maintainer approves, consider this mentor approval.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-06-11 18:48:28 UTC 
A commit references this bug:

Author: bofh
Date: Tue Jun 11 18:47:33 UTC 2019
New revision: 503974
URL: https://svnweb.freebsd.org/changeset/ports/503974

Log:
  graphics/ipe: fix build with GCC-based architectures

  PR:		238066
  Submitted by:	pkubaj

Changes:
  head/graphics/ipe/Makefile
  head/graphics/ipe/files/patch-ipelib_ipeplatform.cpp
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2019-06-11 18:50:16 UTC 
(In reply to Mark Linimon from comment #1)
I am sorry, I missed this comment. Otherwise I would have let pkubaj commit this one. Happy porting.