Created attachment 204658 [details] Update to 1.12.0 - Update to 1.12.0 [1] - Clean up patches due to upstream whitespace cleanup/changes - VVV NNTP broken with 1.12.0 - VVV quote patch broken. Add to files/ until fixed upstream. - Update extra-patch-maildir-mtime* due to upstream 6317a30369e - Remove extra-patch-smime-outlook Code [2] backing this patch was removed and as far as I can tell should have never been enabled in the first place. Very little documention claiming the what's broken or fixes with Outlook compatiblity [3]. Most likey something from 10+ years ago. [1] http://www.mutt.org/relnotes/1.12/ [2] https://gitlab.com/muttmua/mutt/commit/3aa8d8a [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=328655#41
Hi I think you forgot to include updated extra-patch-${VVV_PATCH_VERSION}.vvv.quote Also, I plan to remove #PORTREVISION= 0 line, there are no slave mutt ports anymore, so it's useless. I hope you don't mind.
(In reply to Alex Kozlov from comment #1) You're right. Good catch. It's here locally but I forgot to add it to the repo before making the diff. I can create a new patch later today or can you just plop this down in files? https://gist.github.com/derekschrock/85ea0f2d107080c95c328598b17e73d8 You're right about mail/mutt not being a master port anymore however PORTREVISION can and should still be used. I keep the PORTREVISION= around (even as a comment) as a reminder that it exists and mild lazyness such that I don't have to type it and know the section/location to keep portlint happy. If there is a policy such that comments like this should be removed please do so.
A commit references this bug: Author: ak Date: Wed May 29 17:41:38 UTC 2019 New revision: 502978 URL: https://svnweb.freebsd.org/changeset/ports/502978 Log: - Update to 1.12.0 [*] - Clean up patches due to upstream whitespace cleanup/changes - Mark NNTP patch broken with 1.12.0 - VVV quote patch broken. Add to files/ fixed version until updated upstream - Update extra-patch-maildir-mtime* due to upstream 6317a30369e - Remove extra-patch-smime-outlook. The code [2] backing this patch was removed [*] http://www.mutt.org/relnotes/1.12/ PR: 238179 Submitted by: Derek Schrock <dereks@lifeofadishwasher.com> (maintainer) Changes: head/mail/mutt/Makefile head/mail/mutt/distinfo head/mail/mutt/files/extra-patch-ifdef head/mail/mutt/files/extra-patch-maildir-mtime head/mail/mutt/files/extra-patch-maildir-mtime-nntp head/mail/mutt/files/extra-patch-reverse_reply head/mail/mutt/files/extra-patch-smartdate head/mail/mutt/files/extra-patch-smime-outlook head/mail/mutt/files/extra-patch-vvv.quote head/mail/mutt/files/patch-Makefile.in head/mail/mutt/files/patch-browser.c head/mail/mutt/files/patch-contrib_Makefile.in head/mail/mutt/files/patch-date-conditional head/mail/mutt/files/patch-dgc-deepif head/mail/mutt/files/patch-doc_Makefile.in head/mail/mutt/files/patch-doc_Muttrc head/mail/mutt/files/patch-muttlib.c head/mail/mutt/files/patch-smime-sender head/mail/mutt/files/patch-threadcomplete head/mail/mutt/pkg-plist
Hi The SMIME_OUTLOOK_COMPAT option's name is a little misleading, it's actually disable some obscure outlook compatibility, as described in debian's bug[1]. As I can understand, that bug was closed due to timeout and later code for disabling that compatibility was removed, so now it's enabled by default[2]. It's easy to restore, but it seems to be a minor thing, so for now I'll go with upstream. I you want to restore that option, please update this pr or open a new one. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=328655#41 [2] https://gitlab.com/muttmua/mutt/commit/3aa8d8a