Is there a reason that the openblas port does not install f77blas.h and openblas_config.h? biology/gemma, for example uses openblas_config.h. I've hacked around it for now, but would like to remove the patch at some point. As the port installs both single- and multi-threaded libraries, we should probably have a separate openblas_config.h for each. Thanks, JB
Hello, I agree to install OpenBLAS header files. Mr. Popov created a Phabricator review. https://reviews.freebsd.org/D20866 Please take a look at this.
I got a suggestion to rename "config.h" and "common.h" to "openblas_config.h" and "openblas_common.h" respectively. Former names are too common and can create a clash when used with other projects. That's why I haven't committed it yet. I'll update the diff in near future.
I have updated the Diff. To all whom it concerns, please take a look. Note there is no f77blas.h to install, but there is cblas.h and my patch makes the port install it.
(In reply to Gleb Popov from comment #2) Since config.h is being renamed to openblas_config.h by that diff, openblas_common.h should be also modified at line 62 to include openblas_config.h instead of config.h.
(In reply to Artyom Davidov from comment #4) Thanks for the pointer, I've fixed it.
Thanks Gleb! A small side-note. It looks like the port option DYNAMIC_ARCH is mutually exclusive with the usage of this port via its header files. As far as I understand the CPU optimizations that will be used by this port is being configured by the settings in openblas_config.h (config.h) that is being generated during build time. With DYNAMIC_ARCH enabled I always get openblas_config.h populated with the setting for the NEHALEM CPU family though my test build machine have another CPU type (family). I didn't dig in to this further due to the absence of time, but maybe some one can test this behavior and comment on this. But from the first look it seems that building this port with DYNAMIC_ARCH enabled and using it via the header files would lead to undesired behavior.
I approve your new patch. Please commit it. Thank you for your contribution!
A commit references this bug: Author: arrowd Date: Tue Oct 29 10:25:43 UTC 2019 New revision: 515970 URL: https://svnweb.freebsd.org/changeset/ports/515970 Log: math/openblas: Install header files. PR: 238228 Reviewed by: Artyom Davidov <ard_1@mail.ru> Approved by: Eijiro Shibusawa <phd_kimberlite@yahoo.co.jp> (maintainer) Differential Revision: https://reviews.freebsd.org/D20866 Changes: head/math/openblas/Makefile head/math/openblas/pkg-plist
Thanks, guys!
After this commit: ===>>> Building the port required 2848 seconds ===> Staging for openblas-0.2.20_11,1 ===> Generating temporary packing list install -m 0644 /tmp/work/usr/ports/math/openblas/work/lib/libopenblas.a /tmp/work/usr/ports/math/openblas/work/stage/usr/local/lib install -s -m 0644 /tmp/work/usr/ports/math/openblas/work/lib/libopenblas.so.0 /tmp/work/usr/ports/math/openblas/work/stage/usr/local/lib /bin/ln -sf libopenblas.so.0 /tmp/work/usr/ports/math/openblas/work/stage/usr/local/lib/libopenblas.so install -m 0644 /tmp/work/usr/ports/math/openblas/work/lib/libopenblasp.a /tmp/work/usr/ports/math/openblas/work/stage/usr/local/lib install -s -m 0644 /tmp/work/usr/ports/math/openblas/work/lib/libopenblasp.so.0 /tmp/work/usr/ports/math/openblas/work/stage/usr/local/lib /bin/ln -sf libopenblasp.so.0 /tmp/work/usr/ports/math/openblas/work/stage/usr/local/lib/libopenblasp.so cd /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20 && /usr/bin/find . -name 'common*.h' -print | /usr/bin/xargs /usr/bin/basename | /usr/bin/xargs -I {} /bin/mv {} openblas_{} /bin/mv /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/version.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/openblas_version.h /bin/mv /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/param.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/openblas_param.h /bin/mv /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/cpuid.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/openblas_cpuid.h /bin/mv /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/config.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/openblas_config.h /usr/bin/sed -i.bak -e 's/"common.h"/"openblas_common.h"/' -e 's/"version.h"/"openblas_version.h"/' -e 's/"param.h"/"openblas_param.h"/' -e 's/"cpuid.h"/"openblas_cpuid.h"/' -e 's/"config.h"/"openblas_config.h"/' -e 's/"common_/"openblas_common_/' /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/*.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/*.c /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/interface/*.c /bin/mkdir -p /tmp/work/usr/ports/math/openblas/work/stage/usr/local/include/openblas install -m 0644 /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/openblas_*.h /tmp/work/usr/ports/math/openblas/work/stage/usr/local/include/openblas install -m 0644 /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/cblas.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/config_kernel.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/config_last.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/l1param.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/l2param.h /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/symcopy.h /tmp/work/usr/ports/math/openblas/work/stage/usr/local/include/openblas install: /tmp/work/usr/ports/math/openblas/work/OpenBLAS-0.2.20/config_kernel.h: No such file or directory *** Error code 71 Same on 12.0 amd64 and i386.
OPTIONS_FILE_UNSET+=AVX OPTIONS_FILE_UNSET+=AVX2 OPTIONS_FILE_UNSET+=DYNAMIC_ARCH OPTIONS_FILE_UNSET+=INTERFACE64 OPTIONS_FILE_UNSET+=OPENMP
Created attachment 208717 [details] Patch to fix config_kernel.h staging issue This patch will fix the config_kernel.h staging issue when DYNAMIC_ARCH option is disabled.
Created attachment 208718 [details] Synth test build logs for config_kernel.h fix This archive contains two math/openblas Synth test build log files for the config_kernel.h fix with DYNAMIC_ARCH set to disabled and enabled. Sorry for the 7zip, but the logs are huge and they don't get compressed well enough with gzip to fit in 1MB limit.
(In reply to Artyom Davidov from comment #13) Thanks for patch! > Sorry for the 7zip, but the logs are huge and they don't get compressed well enough with gzip to fit in 1MB limit. xz tar -J
A commit references this bug: Author: arrowd Date: Thu Oct 31 13:21:46 UTC 2019 New revision: 516146 URL: https://svnweb.freebsd.org/changeset/ports/516146 Log: math/openblas: Fix build with DYNAMIC_ARCH=OFF. PR: 238228 Submitted by: Artyom Davidov <ard_1@mail.ru> Changes: head/math/openblas/Makefile head/math/openblas/pkg-plist