Bug 238339 - audio/shairport-sync: fix build with GCC-based architectures
Summary: audio/shairport-sync: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-05 15:45 UTC by Piotr Kubaj
Modified: 2019-06-08 13:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
patch (427 bytes, patch)
2019-06-05 15:45 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (ehaupt)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-06-05 15:45:44 UTC 
Created attachment 204842 [details]
patch

Remove -Wno-clobbered -Wno-psabi which are not supported by base GCC.

Tested to still build fine with clang.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-06-08 12:46:04 UTC 
A commit references this bug:

Author: ehaupt
Date: Sat Jun  8 12:45:24 UTC 2019
New revision: 503724
URL: https://svnweb.freebsd.org/changeset/ports/503724

Log:
  - Update to 3.3.1
  - Remove -Wno-clobbered -Wno-psabi which are not supported by base GCC
    (relevant for some Tier-2 archs) [1]

  PR:		238339 [1]
  Submitted by:	pkubaj [1]

Changes:
  head/audio/shairport-sync/Makefile
  head/audio/shairport-sync/distinfo
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2019-06-08 12:48:26 UTC 
Committed with minor modifications, thanks!

Modifications:

- Updated the port to 3.3.1
- .include <bsd.port.pre.mk> is not needed for post-patch
- ${REINPLACE_CMD} needs to be silenced by BHB rule