Bug 238341 - devel/psptoolchain-newlib: fix to recent change that made library unusable
Summary: devel/psptoolchain-newlib: fix to recent change that made library unusable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-05 16:30 UTC by Tassilo Philipp
Modified: 2019-06-08 07:06 UTC (History)
0 users

See Also:

Attachments
patch (632 bytes, patch)
2019-06-05 16:30 UTC, Tassilo Philipp 		tphilipp: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tassilo Philipp 2019-06-05 16:30:10 UTC 
Created attachment 204843 [details]
patch

Fix to change introduced by commit rP499897 [1] which broke the use of the library. There is no libssp with the PSP SDK, so enabling stack guards results in unresolved symbols for people trying to use it.

[1] https://reviews.freebsd.org/rP499897#change-EMNZLl9YUhUp
Comment 1 Tassilo Philipp 2019-06-05 18:10:14 UTC 
Sorry, I didn't dig deep enough, so correction: the problem actually already happened when SSP_CFLAGS was added, the commit mentioned merely kept the port building. That said, the patch is still working and fixes the use of the library, as described. However, I'm wondering if using WITHOUT_SSP would be better? I lean towards the patch, as-is, to explicitly disabe the stack guards.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-06-08 00:24:00 UTC 
A commit references this bug:

Author: swills
Date: Sat Jun  8 00:23:43 UTC 2019
New revision: 503680
URL: https://svnweb.freebsd.org/changeset/ports/503680

Log:
  devel/psptoolchain-newlib: fix to recent change that made library unusable

  PR:		238341
  Submitted by:	Tassilo Philipp <tphilipp@potion-studios.com> (maintainer)

Changes:
  head/devel/psptoolchain-newlib/Makefile
Comment 3 Steve Wills freebsd_committer freebsd_triage 2019-06-08 00:24:52 UTC 
Committed, slightly modified so it's more explicit. Thanks!
Comment 4 Tassilo Philipp 2019-06-08 07:06:20 UTC 
Thanks! I think you wanted to remove the SSP_CFLAGS?= line, though, as you did with PR 238342?