Bug 238539 - games/wop: fix build with GCC-based architectures
Summary: games/wop: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-13 07:49 UTC by Piotr Kubaj
Modified: 2019-06-13 12:15 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
patch (575 bytes, patch)
2019-06-13 07:49 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (amdmi3)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-06-13 07:49:03 UTC 
Created attachment 205027 [details]
patch

Add -Wno-c++11-narrowing -Wno-reserved-user-defined-literal only when using clang, it fails with base gcc.

While here, add USES=sdl.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-06-13 12:13:18 UTC 
There was a race condition between pkubaj and I working on the same problem.  I had already committed the flags patch.

I will commit the USES patch though; I must have missed seeing it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-06-13 12:15:19 UTC 
A commit references this bug:

Author: linimon
Date: Thu Jun 13 12:14:55 UTC 2019
New revision: 504083
URL: https://svnweb.freebsd.org/changeset/ports/504083

Log:
  Add sdl to USES.

  PR 238539 came in right after I had independently done the flags commit.
  So, commit this part of that PR to clean up after myself.

  PR:		238539
  Submitted by:	pkubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/games/wop/Makefile