Created attachment 205113 [details] Replace /usr/local with ${PREFIX} On a system with PREFIX being something other than /usr/local, the post-install target fails to remove the ${STAGEDIR}/usr/local/llvm80/include/llvm/TextAPI/MachO ... The trivial fix is attached, however, I'd suggest using "${RM} -r" instead of ${RMDIR}" because the latter will gratuitously fail upon a rerun of the staging.
Comment on attachment 205113 [details] Replace /usr/local with ${PREFIX} Approved by: portmgr (blanket(s): just fix it, ports compliance)
@Mikhail The change is a blanket approval candidate. Feel free to assign yourself, commit, mfh (if appropriate, I haven't looked), and close
Thanks! I'll commit shortly. The RMDIR won't fail on restage because the directory is always (re)created during the do-install phase. I prefer RMDIR because it will start failing if upstream starts putting files in the directory.
A commit references this bug: Author: brooks Date: Mon Jun 17 20:52:16 UTC 2019 New revision: 504435 URL: https://svnweb.freebsd.org/changeset/ports/504435 Log: Fix a bug when ${PREFIX} != /usr/local.[0] As of LLVM 8.0.1, pre-releases have moved to github. Chase this change. PR: 238603 [0] Submitted by: mi [0] MFH: 2019Q2 Changes: head/devel/llvm80/Makefile head/devel/llvm80/distinfo
A commit references this bug: Author: brooks Date: Tue Jun 18 17:46:42 UTC 2019 New revision: 504489 URL: https://svnweb.freebsd.org/changeset/ports/504489 Log: MFH: r504435 r504436 Fix a bug when ${PREFIX} != /usr/local.[0] As of LLVM 8.0.1, pre-releases have moved to github. Chase this change. PR: 238603 [0] Submitted by: mi [0] Revert accidental update to distinfo. Reported by: Christoph Moench-Tegeder <cmt@burggraben.net> Approved by: portmgr (blanket fixes) Changes: _U branches/2019Q2/ branches/2019Q2/devel/llvm80/Makefile branches/2019Q2/devel/llvm80/distinfo