Bug 238904 - devel/ocaml-findlib: extra file META (check-plist error)
Summary: devel/ocaml-findlib: extra file META (check-plist error)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-01 03:41 UTC by John Hein
Modified: 2022-04-25 07:39 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (hrs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2019-07-01 03:41:10 UTC 
'make -C /usr/ports/devel/ocaml-findlib check-plist' gives the following error:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%OCAML_SITELIBDIR%%/ocamlbuild/META
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Comment 1 John Hein 2019-07-01 03:47:15 UTC 
CC danfe.  It looks like r505020 introduced this problem.  Note that ocaml-ocamlbuild was installed before trying to build ocaml-findlib:

% pkg info -q | grep ocaml
ocaml-4.05.0
ocaml-camlp4-4.05+2
ocaml-labltk-8.06.3
ocaml-ocamlbuild-0.14.0
Comment 2 John Hein 2019-07-01 04:06:25 UTC 
See also bug 238905 for another ocaml-ocamlbuild & ocaml-findlib build interaction problem.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-25 06:58:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3a710a0c04d680983779abc5152ad72a4122c833

commit 3a710a0c04d680983779abc5152ad72a4122c833
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-04-25 06:54:24 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-04-25 06:54:24 +0000

    devel/ocaml-findlib: the port had been updated to version 1.8.1

    - This is not the latest version, but this step lubricates coming
      next phase of our OCaml stack update
    - Since we're post-4.06 now, remove support for Num library which
      is a separate port/package
    - Detect optionally installed libraries and adjust the packaging
      list accordingly
    - Spell `Tk' correctly in the TOOLBOX option description

    PR:     238904, 262791

 devel/ocaml-findlib/Makefile                         | 17 ++++++++---------
 devel/ocaml-findlib/distinfo                         |  6 +++---
 devel/ocaml-findlib/files/patch-configure (gone)     | 12 ------------
 devel/ocaml-findlib/files/patch-src_findlib_Makefile |  2 +-
 devel/ocaml-findlib/pkg-plist                        |  6 +-----
 5 files changed, 13 insertions(+), 30 deletions(-)
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-04-25 07:39:04 UTC 
(In reply to John Hein from comment #1)
> Note that ocaml-ocamlbuild was installed before trying to build ocaml-findlib
That was the problem: while ocamlbuild is not required for the build, ocamlbuild/META file would be installed if it's found in the system.  This situation should be handled correctly now after ports 3a710a0c04d6.