Bug 239023 (pyqt-5.13.0) - [exp-run] Update pyqt to 5.13.0 (with it sip to 4.19.18 and qscintilla to 2.11.2)
Summary: [exp-run] Update pyqt to 5.13.0 (with it sip to 4.19.18 and qscintilla to 2.1...
Status: Closed FIXED
Alias: pyqt-5.13.0
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL: https://github.com/freebsd/freebsd-po...
Keywords:
Depends on: 238782
Blocks:
  Show dependency tree / graph
 
Reported: 2019-07-06 18:39 UTC by Tobias C. Berner
Modified: 2019-10-18 06:58 UTC (History)
2 users (show)

See Also:
antoine: exp-run+

Attachments
v1 (10.16 KB, patch)
2019-07-06 18:39 UTC, Tobias C. Berner 		no flags Details | Diff
v2 (12.67 KB, patch)
2019-10-12 13:36 UTC, Adriaan de Groot 		no flags Details | Diff
v3 (11.20 KB, patch)
2019-10-17 10:09 UTC, Tobias C. Berner 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer freebsd_triage 2019-07-06 18:39:53 UTC 
Created attachment 205549 [details]
v1

Hi there

kde@ would like to ask for an exp-run to upgrade PyQt to 5.13.0. This requirs the changes from pr 238782 .


The patch is attached and can also be found here:
https://people.freebsd.org/~tcberner/patches/pyqt5-5.13.0.v1.diff


mfg Tobias
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2019-10-12 13:36:34 UTC 
Created attachment 208263 [details]
v2

This is v2 of the patch; with it Calibre (and all other ports with USE_PYQT) build locally. It's a bit muddy -- we now **don't** patch out building Qt.so in patch-configure.py, but **do** remove the resulting file because it blocks Calibre.
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2019-10-17 10:09:16 UTC 
Created attachment 208379 [details]
v3

This removes the mistakenly added patch in messagelib.

https://people.freebsd.org/~tcberner/patches/pyqt-5.13.0.v3.diff
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2019-10-18 05:38:47 UTC 
Exp-run looks fine
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-10-18 06:58:19 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Oct 18 06:57:29 UTC 2019
New revision: 514705
URL: https://svnweb.freebsd.org/changeset/ports/514705

Log:
  PyQt: Update to 5.13.0

  Updates
  - PyQt to 5.13.0
  - sip to 4.19.18
  - qscintilla to 2.11.2

  PR:		239023
  Exp-run by:	antoine

Changes:
  head/Mk/Uses/pyqt.mk
  head/devel/py-qt5/distinfo
  head/devel/py-qt5-core/Makefile
  head/devel/py-qt5-core/files/patch-configure.py
  head/devel/py-qt5-core/pkg-plist
  head/devel/py-qt5-help/pkg-plist
  head/devel/py-sip/distinfo
  head/devel/qscintilla2-qt5/distinfo
  head/devel/qscintilla2-qt5/pkg-plist
  head/net/py-qt5-network/pkg-plist
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2019-10-18 06:58:38 UTC 
Thanks for the exp-run.