Bug 239254 - devel/libzookeeper: build is broken after r506594
Summary: devel/libzookeeper: build is broken after r506594
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steven Kreuzer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-07-16 16:54 UTC by Sergey Akhmatov
Modified: 2019-07-17 01:02 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (skreuzer)


Attachments
libzookeeper-pkgconfig.patch (369 bytes, patch)
2019-07-16 16:54 UTC, Sergey Akhmatov
sergey: maintainer-approval? (skreuzer)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akhmatov 2019-07-16 16:54:28 UTC
Created attachment 205823 [details]
libzookeeper-pkgconfig.patch

Poudriere testport:

===>  Configuring for libzookeeper-3.5.5
acinclude.m4:315: warning: macro 'AM_PATH_CPPUNIT' not found in library
configure.ac:37: error: Missing AM_PATH_CPPUNIT or PKG_CHECK_MODULES m4 macro.
acinclude.m4:317: CHECK_CPPUNIT is expanded from...
configure.ac:37: the top level
autom4te-2.69: /usr/local/bin/gm4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1
autoreconf-2.69: aclocal failed with exit status: 1
*** Error code 1
===

PKG_CHECK_MODULES is defined in pkgconf, so adding: "USES= pkgconfig" fixes build for me. See the attached patch.

QA: Poudriere testport OK on 11.2, 11.3 & 12.0
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-07-17 01:01:37 UTC
A commit references this bug:

Author: skreuzer
Date: Wed Jul 17 01:01:09 UTC 2019
New revision: 506785
URL: https://svnweb.freebsd.org/changeset/ports/506785

Log:
  Fix Poudriere build failure

  PKG_CHECK_MODULES is defined in pkgconf, so add "USES= pkgconfig"

  PR:		239254
  Submitted by:	Sergey Akhmatov <sergey@akhmatov.ru>

Changes:
  head/devel/libzookeeper/Makefile
Comment 2 Steven Kreuzer freebsd_committer freebsd_triage 2019-07-17 01:02:25 UTC
Committed. Thanks!