Bug 239346 - graphics/librsvg2: drop libgsf and gettext-tools dependencies, add DOCS option
Summary: graphics/librsvg2: drop libgsf and gettext-tools dependencies, add DOCS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-desktop (Team)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-07-20 16:19 UTC by Andriy Voskoboinyk
Modified: 2021-12-06 21:08 UTC (History)
3 users (show)

See Also:
avos: exp-run?

Attachments
Makefile, pkg-plist and gnome.mk diff (4.99 KB, patch)
2019-07-20 16:19 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Output of portlint -AC (229 bytes, text/plain)
2019-07-20 16:21 UTC, Andriy Voskoboinyk 		no flags Details
12amd64 poudriere build log (DOCS=on) (164.94 KB, text/plain)
2019-07-20 16:22 UTC, Andriy Voskoboinyk 		no flags Details
12amd64 poudriere build log (DOCS=off) (164.95 KB, text/plain)
2019-07-20 16:22 UTC, Andriy Voskoboinyk 		no flags Details
12i386 poudriere build log (DOCS=on) (164.82 KB, text/plain)
2019-07-20 16:23 UTC, Andriy Voskoboinyk 		no flags Details
12i386 poudriere build log (DOCS=off) (164.83 KB, text/plain)
2019-07-20 16:24 UTC, Andriy Voskoboinyk 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-20 16:19:16 UTC 
Created attachment 205939 [details]
Makefile, pkg-plist and gnome.mk diff

Remove devel/libgsf dependency since was removed some time ago (entry from ChangeLog):

commit 59a3fed362fd70e29452fce58d8324cc00e7cc7e
Author: Christian Persch <chpe@gnome.org>
Date:   Sat Oct 22 19:03:27 2011 +0200

    Drop GSF support
    
    Update GIO req to 2.24, and just always use GIO for gzip support.

and remove it from Mk/Uses/gnome.mk accordingly (probably requires an exp-run).

Remove gettext-tools build dependency too (not used by the port).

While here, sort USES / DEPENDS (portlint) and add DOCS option (checked locally with make DOCSDIR=/opt/share/doc).

Bump PORTREVISION since the package will change.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-20 16:21:09 UTC 
Created attachment 205940 [details]
Output of portlint -AC
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-20 16:22:28 UTC 
Created attachment 205942 [details]
12amd64 poudriere build log (DOCS=on)
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-20 16:22:52 UTC 
Created attachment 205944 [details]
12amd64 poudriere build log (DOCS=off)
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-20 16:23:40 UTC 
Created attachment 205945 [details]
12i386 poudriere build log (DOCS=on)
Comment 5 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-20 16:24:14 UTC 
Created attachment 205946 [details]
12i386 poudriere build log (DOCS=off)
Comment 6 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-07-21 01:15:00 UTC 
patch-ready -> patch (looks like I should not set this flag - from https://wiki.freebsd.org/KubilayKocak/Bugzilla/DosAndDonts )
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-12-06 19:58:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=154ff63388716dfe5643f099914e8078106d4a97

commit 154ff63388716dfe5643f099914e8078106d4a97
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2021-12-06 19:31:56 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2021-12-06 19:55:57 +0000

    graphics/librsvg2: add options, remove libgsf dependency

    This is a combination of patches from two PRs, from Andriy Voskoboinyk
    and Andrew Romanenko, which have been languishing. Both added a DOCS
    option, and Andrew makes Vala optional while Andriy removes an unneeded
    dependency on libgsf and gettext.

    Note that graphics/librsvg2 is the outdated version, used only on
    platforms where the newer librsvg2-rust is not available.

    PR:             243071 239346
    Reported by:    Andrew Romanenkom, Andriy Voskoboinyk

 Mk/Uses/gnome.mk            |  2 +-
 graphics/librsvg2/Makefile  | 31 ++++++++++++++++++++++---------
 graphics/librsvg2/pkg-plist | 42 +++++++++++++++++++++---------------------
 3 files changed, 44 insertions(+), 31 deletions(-)