Bug 240314 - net/nats-streaming-server: Unbreak with go1.13
Summary: net/nats-streaming-server: Unbreak with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-03 18:12 UTC by Dmitri Goutnik
Modified: 2019-09-09 13:18 UTC (History)
1 user (show)

See Also:
olgeni: maintainer-feedback+

Attachments
patch file (1.20 KB, patch)
2019-09-03 18:12 UTC, Dmitri Goutnik 		no flags Details | Diff
patch file (436 bytes, patch)
2019-09-09 12:19 UTC, Dmitri Goutnik 		olgeni: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-03 18:12:32 UTC 
Created attachment 207158 [details]
patch file

===>  Building for nats-streaming-server-0.15.0
go: github.com/go-sql-driver/mysql@v1.4.1: Get https://proxy.golang.org/github.com/go-sql-driver/mysql/@v/v1.4.1.mod: dial tcp: lookup proxy.golang.org on 209.222.18.218:53: write udp 127.0.0.1:51039->209.222.18.218:53: write: permission denied
*** Error code 1

- Update 0.15.0 -> 0.16.0
- Switch to USES=go:modules, this also fixes the build with go1.13
- Remove GO_PKGNAME, not needed with modules

QA:
  poudriere testport: OK (120a-go1.12.9, 120a-go-devel)
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-09-08 12:27:18 UTC 
Ports is marked broken as of ports r511545.  I would have committed under the
just-fix-it blanket but this is also a version update, so leaving it alone for
now.
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-09 12:19:30 UTC 
Created attachment 207322 [details]
patch file

Just unbreak, postpone the update for later.
Comment 3 Jimmy Olgeni freebsd_committer freebsd_triage 2019-09-09 12:41:32 UTC 
Comment on attachment 207322 [details]
patch file

Fine for me - if you wish to rename/upgrade the port, please go ahead.

Thank you!
Comment 4 Jimmy Olgeni freebsd_committer freebsd_triage 2019-09-09 12:44:09 UTC 
(In reply to Tobias Kortkamp from comment #1)

Can you please take care of this? I'm away from my usual setup (actually typing from a Raspberry!)
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2019-09-09 13:17:41 UTC 
Committed. Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-09-09 13:18:29 UTC 
A commit references this bug:

Author: tobik
Date: Mon Sep  9 13:17:35 UTC 2019
New revision: 511628
URL: https://svnweb.freebsd.org/changeset/ports/511628

Log:
  net/nats-streaming-server: Unbreak with go1.13

  ===>  Building for nats-streaming-server-0.15.0
  go: github.com/go-sql-driver/mysql@v1.4.1: Get https://proxy.golang.org/github.com/go-sql-driver/mysql/@v/v1.4.1.mod: dial tcp: lookup proxy.golang.org on 209.222.18.218:53: write udp 127.0.0.1:51039->209.222.18.218:53: write: permission denied
  *** Error code 1

  - Switch to USES=go:modules
  - Remove GO_PKGNAME, not needed with modules

  PR:		240314
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Approved by:	olgeni (maintainer)
  Pointy hat:	jlaffaye

Changes:
  head/net/nats-streaming-server/Makefile