Bug 240319 - devel/ghq: Unbreak with go1.13
Summary: devel/ghq: Unbreak with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-03 19:39 UTC by Dmitri Goutnik
Modified: 2019-09-04 08:58 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tobik)

Attachments
patch file (2.02 KB, patch)
2019-09-03 19:39 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (tobik)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-03 19:39:41 UTC 
Created attachment 207164 [details]
patch file

===>  Building for ghq-0.12.6
...
# golang.org/x/xerrors
vendor/golang.org/x/xerrors/adaptor_go1_13.go:16:14: undefined: errors.Frame
vendor/golang.org/x/xerrors/format_go1_13.go:12:18: undefined: errors.Formatter
...
*** Error code 2

- Unbreak by updating golang.org/x/xerrors commit ID to a985d3407aa7 [1]

[1] https://github.com/golang/xerrors/commit/a985d3407aa71f30cf86696ee0a2f409709f22e1

QA:
  poudriere testport: OK (120a-go1.12.9, 120a-go-devel)
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-09-04 08:56:31 UTC 
A commit references this bug:

Author: tobik
Date: Wed Sep  4 08:56:28 UTC 2019
New revision: 511067
URL: https://svnweb.freebsd.org/changeset/ports/511067

Log:
  devel/ghq: Unbreak with go1.13

  ===>  Building for ghq-0.12.6
  ...
  # golang.org/x/xerrors
  vendor/golang.org/x/xerrors/adaptor_go1_13.go:16:14: undefined: errors.Frame
  vendor/golang.org/x/xerrors/format_go1_13.go:12:18: undefined: errors.Formatter
  ...
  *** Error code 2

  - Unbreak by updating golang.org/x/xerrors to [1]

  [1] https://github.com/golang/xerrors/commit/a985d3407aa71f30cf86696ee0a2f409709f22e1

  PR:		240319
  Submitted by:	Dmitri Goutnik <dg@syrec.org>

Changes:
  head/devel/ghq/Makefile
  head/devel/ghq/distinfo
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-09-04 08:58:30 UTC 
Committed. Thanks for your work.

A shame that lang/go was updated to 1.13 without an exp-run or landing all
of your go1.13 PRs ahead of time. :-(