Bug 240385 - accessibility/orca misplaced period (.) in description
Summary: accessibility/orca misplaced period (.) in description
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kubilay Kocak
URL: https://www.freshports.org/accessibil...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-07 06:10 UTC by Graham Perrin
Modified: 2019-09-07 06:36 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2019-09-07 06:10:09 UTC 
Nit, at the tail of the first paragraph: 

<http://live.gnome.org/Orca.>

– the trailing . causes the link to not redirect as expected
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2019-09-07 06:18:09 UTC 
Sorry, preview didn't work so I couldn't predict that the link in comment 0 would not represent the link at FreshPorts web page. 

The end result of following the link is: 

https://wiki.gnome.org/Orca. with a trailing period, a page that does not exist.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-07 06:27:28 UTC 
URL's at the end of sentences, a renderers (and grammaticist) worst nightmare.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-09-07 06:34:11 UTC 
A commit references this bug:

Author: koobs
Date: Sat Sep  7 06:33:17 UTC 2019
New revision: 511392
URL: https://svnweb.freebsd.org/changeset/ports/511392

Log:
  accessibility/orca: Fix pkg-descr ending with a URL

  A URL ending a sentence, with a full stop after it, causes pain
  for renderers such as freshports.org and other clients that may hyperlink
  them.

  Since the same URL is just below it in the pkg-descr WWW URL, amend
  the sentence to point to it instead.

  PR:		240385
  Reported by:	Graham Perrin <grahamperrin gmail com>
  Approved by:	portmgr (blanket: just fix it)

Changes:
  head/accessibility/orca/Makefile
  head/accessibility/orca/pkg-descr
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-07 06:35:49 UTC 
Thank you for the report Graham

If you're feeling up to it, a search for this kind of issue in other ports pkg-descr's across the whole tree might be good to get all of these in one go/PR :)