Created attachment 207482 [details] gitflow 1.12.3 Update to 1.12.3
Hi, thank you for the patch. I assume that the patch "patch-git-flow-init" is no longer required since upstream has fixed it in 1.12.2: > ===> Applying FreeBSD patches for gitflow-1.12.3_1 > Ignoring previously applied (or reversed) patch. > 1 out of 1 hunks ignored--saving rejects to git-flow-init.rej > => FreeBSD patch patch-git-flow-init failed to apply cleanly. > *** Error code 1 Without the patch everything builds fine. One question: Are there new patches that need to be added? Beside that the line with "PORTREVISION" needs to be removed (or set back to "0") as the "PORTVERSION" was increased. I already removed that line in my local repository so you don't need to update the attached patch if there's nothing more (e.g. additional patches) to add.
Hi, no extra patches required. Thanks :)
A commit references this bug: Author: kai Date: Mon Sep 16 10:08:30 UTC 2019 New revision: 512155 URL: https://svnweb.freebsd.org/changeset/ports/512155 Log: devel/gitflow: Update to 1.12.3 * Remove patch "patch-git-flow-init" that is no longer required. [1] While I'm here: * Group USES block with related USE_ variables and move OPTIONS_DEFINE further down according to the PHB. Changelog since 1.12.1: * Explicitly get the default values from the system and global config * Fix missing parentheses [1] PR: 240577 Submitted by: nbari@tequila.io (maintainer) Changes: head/devel/gitflow/Makefile head/devel/gitflow/distinfo head/devel/gitflow/files/
(In reply to nbari from comment #2) Committed, thank you for the patch and the quick reply! One pro-tip for your next submission: You can speed up the process by setting "maintainer-approval" (not to be confused with the "maintainer-feedback" flag) on the attachment to "+" for ports you maintain. ;)
Got it, many thanks :-)