Created attachment 207610 [details] update patch against glassfish (4) We currently ship glassfish 4 and have glassfish5 as an independent port. The news is Java EE was donated to the Eclipse Foundation and they have released Eclipse GlassFish 5.1.0, so perhaps it is better to point there from now on. Disclaimer: I don't use this so someone that knows better should review.
Can you regenerate against the glassfish5 port? I'd like to use that as a staging area before proposing the glassfish port be updated. At that point we may want to retain glassfish4 to support deployments going forward. Thanks!
Created attachment 207611 [details] Update against glassfish5 OK... I actually started from the glassfish5 port for the update :). Note that you should take a look at GLASSFISH_BIN_FILES. I didn't really look at those and they may have changed.
A commit references this bug: Author: jmd Date: Sun Sep 22 01:16:52 UTC 2019 New revision: 512546 URL: https://svnweb.freebsd.org/changeset/ports/512546 Log: www/glassfish5: update to 5.1.0 5.1.0 is the first release under Eclipse Foundation stewardship. Release notes: https://eclipse-ee4j.github.io/glassfish/docs/5.1.0/release-notes/preface.html PR: 240674 Submitted by: pfg@ (minor adaptations) Changes: head/www/glassfish5/Makefile head/www/glassfish5/distinfo head/www/glassfish5/pkg-descr head/www/glassfish5/pkg-plist
Thanks, committed!
For the record: The github repository https://github.com/eclipse-ee4j/glassfish states the requirement is JDK8+, and the tests are usually done with Oracle JDK 8, so I think whil JDK11 is desirable, the stirct requirement should be 8+.
More clearly, from the release notes: https://eclipse-ee4j.github.io/glassfish/docs/5.1.0/release-notes/release-notes.html#GSRLN00246 Required JDK Versions Eclipse GlassFish Server Release 5.1 requires Oracle JDK 8 Update 144 or later.