Bug 240703 - audio/protracker: fix build on GCC architectures
Summary: audio/protracker: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-20 07:45 UTC by Piotr Kubaj
Modified: 2019-09-21 16:36 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)
koobs: merge-quarterly?

Attachments
patch (324 bytes, patch)
2019-09-20 07:45 UTC, Piotr Kubaj 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-09-20 07:45:31 UTC 
Created attachment 207645 [details]
patch

Add USE_CSTD=c99 to fix build:
/wrkdirs/usr/ports/audio/protracker/work/protracker-2.3d.r191/src/pt_visuals.c:1272: error: 'for' loop initial declaration used outside C99 mode
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-20 07:51:41 UTC 
Comment on attachment 207645 [details]
patch

Build fixes are implicitly approved:

Approved by: portmgr (blanket: build fix)
MFH: 2019Q3
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-09-20 16:39:30 UTC 
Approved as mentor pending maintainer review.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-09-21 16:36:29 UTC 
A commit references this bug:

Author: pkubaj
Date: Sat Sep 21 16:36:22 UTC 2019
New revision: 512524
URL: https://svnweb.freebsd.org/changeset/ports/512524

Log:
  audio/protracker: fix build on GCC architectures

  Add USE_CSTD=c99 to fix build:
  /wrkdirs/usr/ports/audio/protracker/work/protracker-2.3d.r191/src/pt_visuals.c:1272: error: 'for' loop initial declaration used outside C99 mode

  PR:		240703
  Approved by:	portmgr (blanket: build fix), linimon (mentor)

Changes:
  head/audio/protracker/Makefile