Bug 240927 - sysutils/iocage: Add necessary dependencies for 1.2
Summary: sysutils/iocage: Add necessary dependencies for 1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Marcelo Araujo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-30 01:58 UTC by Neel Chauhan
Modified: 2019-10-01 06:29 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
Patch (Revision 1) (655 bytes, patch)
2019-09-30 01:58 UTC, Neel Chauhan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2019-09-30 01:58:16 UTC 
Created attachment 207949 [details]
Patch (Revision 1)

This patch adds the necessary dependencies to fix the iocage issues by the GitHub issues here:

https://github.com/iocage/iocage/issues/1049
https://github.com/iocage/iocage/issues/968

I have not tested the patch, so it may not work.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-09-30 02:51:24 UTC 
A commit references this bug:

Author: araujo
Date: Mon Sep 30 02:50:49 UTC 2019
New revision: 513279
URL: https://svnweb.freebsd.org/changeset/ports/513279

Log:
  - Update necessary dependencies for iocage 1.2 release.
  - Bump PORTREVISION.

  PR:		ports/240927
  Submitted by:	Neel Chauhan <neel@neelc.org>
  		Dan Langille <<dan@langille.org>> (via email)
  Reported by:	many

Changes:
  head/sysutils/iocage/Makefile
Comment 2 Marcelo Araujo freebsd_committer freebsd_triage 2019-09-30 02:53:49 UTC 
Thank you for this patch!!!
Comment 3 Adam Jimerson 2019-09-30 16:39:20 UTC 
Note that, since this now depends on devel/git-lite users that have devel/git already installed will have a conflict.

Output of running make package after updating my ports tree:

===>   py36-iocage-1.2_1 depends on package: git-lite>0 - not found


===>  git-lite-2.23.0 conflicts with installed package(s): 
      git-2.23.0

      They install files into the same place.

and I can only assume that this will cause the pkg command to suggest removing the git package in favor of using git-lite (which may cause the user to actually lose git functionality).

Is it possible to change this so either devel/git or devel/git-lite satisfies this dependency?
Comment 4 Adam Jimerson 2019-09-30 16:44:24 UTC 
(In reply to Adam Jimerson from comment #3)

I should have added, I already tested it locally and using devel/git instead of devel/git-lite works to solved the underlying issue as well. I'm just not familiar enough with the ports system to know how to make it so either port works for this.
Comment 5 Marcelo Araujo freebsd_committer freebsd_triage 2019-10-01 04:04:54 UTC 
(In reply to Adam Jimerson from comment #4)

Thanks! I'm working on that.
I might come up with a solution very soon.