Created attachment 208153 [details] fix cdr_pgsql to work with all modern PostgreSQL versions (>8.0) The SQL statement for discovering the cdr table tries to access a column which has been obsolteted for a long time and was removed in PostgreSQL 12 (see upstream bug for full discussion). Attached patch (to be dropped in files/) makes sure cdr_pgsql works with all supported (and much more) versions of PostgreSQL. It should work with net/asterisk13 as well (I'm not filing another, redundant PR for that).
Hi, Thanks for the patch. I'll test it and add it to the port. BTW this patch should be sent upstream so it can be included in the official asterisk sources. Do you allow me to report your name and email as the original source for the patch upstream?
I've already reported this upstream, including patch (despite all their efforts to deter reporters...) - see "URL" link (ASTERISK-28571)
(In reply to Christoph Moench-Tegeder from comment #2) > I've already reported this upstream, including patch > (despite all their efforts to deter reporters...) > - see "URL" link (ASTERISK-28571) Yes, getting patches into their systems is not straightforward, I agree. Since patches sent though their ticketing system are really slow in getting into their tree and I've already proposed a few code reviews in their gerrit thing, I'll make your patch into a proper code review so it can proceed there. (will do this later since it requires a little time to do properly) Thanks!
(In reply to Guido Falsi from comment #3) I think I got that gerrit covered now.
A commit references this bug: Author: madpilot Date: Wed Oct 9 14:27:31 UTC 2019 New revision: 514158 URL: https://svnweb.freebsd.org/changeset/ports/514158 Log: Fix CDR with PostgreSQL 12 PR: 241116 Submitted by: cmt MFH: 2019Q4 Changes: head/net/asterisk13/Makefile head/net/asterisk13/files/patch-cdr_cdr__pgsql.c
A commit references this bug: Author: madpilot Date: Wed Oct 9 14:27:52 UTC 2019 New revision: 514159 URL: https://svnweb.freebsd.org/changeset/ports/514159 Log: Fix CDR with PostgreSQL 12 PR: 241116 Submitted by: cmt MFH: 2019Q4 Changes: head/net/asterisk16/Makefile head/net/asterisk16/files/patch-cdr_cdr__pgsql.c
I added your patch to the port, and will also merge it to quarterly. Will close this bug report once merged. Thanks!
A commit references this bug: Author: madpilot Date: Wed Oct 9 17:45:43 UTC 2019 New revision: 514176 URL: https://svnweb.freebsd.org/changeset/ports/514176 Log: MFH: r514158 r514160 Fix CDR with PostgreSQL 12 PR: 241116 Submitted by: cmt Fix typo. Approved by: ports-secteam (miwi) Changes: _U branches/2019Q4/ branches/2019Q4/net/asterisk13/Makefile branches/2019Q4/net/asterisk13/files/patch-cdr_cdr__pgsql.c
A commit references this bug: Author: madpilot Date: Wed Oct 9 17:46:57 UTC 2019 New revision: 514177 URL: https://svnweb.freebsd.org/changeset/ports/514177 Log: MFH: r514159 Fix CDR with PostgreSQL 12 PR: 241116 Submitted by: cmt Approved by: ports-secteam (miwi) Changes: _U branches/2019Q4/ branches/2019Q4/net/asterisk16/Makefile branches/2019Q4/net/asterisk16/files/patch-cdr_cdr__pgsql.c
Merged. Thanks!