Bug 241203 - math/metis: take maintainership
Summary: math/metis: take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-11 17:54 UTC by Lorenzo Salvadore
Modified: 2019-10-15 15:19 UTC (History)
0 users

See Also:

Attachments
metis - adoption (3.12 KB, patch)
2019-10-11 17:54 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2019-10-11 17:54:12 UTC 
Created attachment 208250 [details]
metis - adoption

I would like to adopt this port.

In the patch I propose many style improvements to make the port much easier to manage, in particular:
- I sort variables more consistently with the standard order;
- I use option helpers, both with variables and with targets.

I tested the patch successfully with poudriere on {11.3,12.0}-RELEASE {i386,amd64}.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-10-15 15:09:35 UTC 
A commit references this bug:

Author: swills
Date: Tue Oct 15 15:09:02 UTC 2019
New revision: 514536
URL: https://svnweb.freebsd.org/changeset/ports/514536

Log:
  math/metis: assign maintainership

  While here, clean up

  PR:		241203
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch>

Changes:
  head/math/metis/Makefile
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-10-15 15:19:34 UTC 
Committed, thanks!