Bug 241249 - devel/lua-sysctl: Fix Makefile options
Summary: devel/lua-sysctl: Fix Makefile options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-14 22:21 UTC by yds
Modified: 2020-01-06 14:23 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (uzsolt)

Attachments
Fix options (1.80 KB, patch)
2019-10-14 22:21 UTC, yds 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yds 2019-10-14 22:21:43 UTC 
Created attachment 208317 [details]
Fix options

Fix Makefile to respect DOCS and EXAMPLES options.

Add options to select which version of Lua to build for.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2019-10-19 15:47:29 UTC 
Sorry for late but only now have time.

I agree about specify Lua version but as I check the Porter's Handbook (https://www.freebsd.org/doc/en/books/porters-handbook/book.html#using-lua) and some other Lua port (for example devel/lua-cjson): doesn't need (and wrong way) create options. The user shouldn't choose Lua version - it specified with LUA_VER variable.

If you want (and have time) do this - do it! :)
If you don't have enough time I'll do it in some days.

Thanks for report!
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-01-06 14:19:52 UTC 
A commit references this bug:

Author: swills
Date: Mon Jan  6 14:18:52 UTC 2020
New revision: 522237
URL: https://svnweb.freebsd.org/changeset/ports/522237

Log:
  devel/lua-sysctl: Fix Makefile to respect DOCS and EXAMPLES options.

  PR:		241249
  Submitted by:	yds <yds@Necessitu.de>
  Approved by:	Zsolt Udvari <uzsolt@uzsolt.hu> (maintainer)

Changes:
  head/devel/lua-sysctl/Makefile
  head/devel/lua-sysctl/pkg-plist
Comment 3 Steve Wills freebsd_committer freebsd_triage 2020-01-06 14:23:02 UTC 
Committed, thanks!