Created attachment 208348 [details] patch to fix p5-WWW-Curl compatibility with curl 7.66 Since perl 7.66 CURL_MULTI_H was replaced by CURLINC_MULTI_H (https://github.com/curl/curl/blob/curl-7_66_0/include/curl/multi.h) So use the patch from Debian (https://salsa.debian.org/perl-team/modules/packages/libwww-curl-perl/commit/3f511f6f825bb6b81c97777dfb357916b6a4d37e)
Important note: Since curl 7.66, using WWW::Curl::Multi with option CURLOPT_CONNECT_TO, crash it too. Sample of p5-WWW-Curl code that work only with version previous to curl 7.66: ------------------ #!/usr/local/bin/perl use strict; use warnings; use WWW::Curl::Easy; use WWW::Curl::Multi; my $multi = WWW::Curl::Multi->new; my $easy = WWW::Curl::Easy->new; $easy->setopt(CURLOPT_PRIVATE, 0); $easy->setopt(CURLOPT_URL, "http://127.0.0.1"); $easy->setopt(CURLOPT_CONNECT_TO, ["127.0.0.1:80"]); $easy->setopt(CURLOPT_HTTPHEADER, ['Connection: close']); $easy->setopt(CURLOPT_WRITEDATA,''); $multi->add_handle($easy); print "Next line should be an expected error: Bad filehandle\n"; print "If there is crash, it's a bug\n"; while ($multi->perform != 0) { print "."; } exit(0); ----------------------
Created attachment 208394 [details] Fix Multi and CONNECT_TO support New version of the patch that fix Multi and CONNECT_TO usage.
A commit references this bug: Author: sunpoet Date: Sun Oct 20 17:21:53 UTC 2019 New revision: 515062 URL: https://svnweb.freebsd.org/changeset/ports/515062 Log: Fix compatibility with curl 7.66 - Bump PORTREVISION for package change PR: 241280 Submitted by: olivier Changes: head/www/p5-WWW-Curl/Makefile head/www/p5-WWW-Curl/files/patch-Curl.xs head/www/p5-WWW-Curl/files/patch-Makefile.PL
Committed. Thanks!