Created attachment 208462 [details] Patch This isn't the most recent version (that would be 8.2.1), but it is fairly recent. There's a significant amount of version churn in the upstream project currently, and I'm waiting on that to settle down before updating further.
Further, 6.5.6 is the most recent signed release: https://github.com/cherrypy/cheroot/releases/tag/v6.5.6
Created attachment 208640 [details] py-cheroot-6.5.6-revised.patch (In reply to Keith Gaughan from comment #0) Hi Keith, thank you for the patch. Attached is a revised version that fixes some issues: - The port devel/py-setuptools_scm_git_archive is required to build otherwise the build process fails in a early stage. - The port devel/py-backports.functools_lru_cache is also required for runtime but only for Python < 3.3. To make this happen we need to backport a patch from the 6.6.0 release for "setup.cfg". - Since ports r515635 we need also to patch "setup.py" with a patch backported from the 8.0 release. - At last but not least: Because the port installs a script (= ${PREFIX}/bin/cheroot) outside the Python environment we need to add the keyword "concurrent" to make the port concurrent safe. If you're fine with the changes and www/py-cheroot works as expected I'm happy then to commit it as soon as possible.
Yeah, that's all fine by me. Thanks for that! I'm not sure why the build didn't break for me. I'd known about the LRU cache issue, but had mentally dismissed it due to the oldest (3 series) version in ports being 3.5, and entirely forgot about 2.7. +2 to the revised patch!
A commit references this bug: Author: kai Date: Mon Oct 28 08:09:35 UTC 2019 New revision: 515848 URL: https://svnweb.freebsd.org/changeset/ports/515848 Log: www/py-cheroot: Update to 6.5.6 * There is currently a signification amount of version churn in the upstream repository so use the most recent signed release for now. * Since release 6.3.0 the port installs a CLI tool outside the Python environment thus make it concurrent safe. * Also backport two patches to retain compatibility with recent versions of devel/py-setuptools and avoid failures at runtime with Python 3 while I'm here. [1] Changelog since 6.0.0: https://github.com/cherrypy/cheroot/blob/v6.5.6/CHANGES.rst PR: 241369 Submitted by: Keith Gaughan <k@stereochro.me> (maintainer) Approved by: Keith Gaughan <k@stereochro.me> (maintainer) [1] MFH: 2019Q4 Changes: head/www/py-cheroot/Makefile head/www/py-cheroot/distinfo head/www/py-cheroot/files/ head/www/py-cheroot/files/patch-setup.cfg head/www/py-cheroot/files/patch-setup.py
(In reply to Keith Gaughan from comment #3) Thank you for the quick approval. The changes were committed to the head branch. I'll try to merge them into the 2019Q4 branch if I get approval from the ports-secteam.
Comment on attachment 208640 [details] py-cheroot-6.5.6-revised.patch ^ Triage: maintainer-approval was given in comment #3
A commit references this bug: Author: kai Date: Wed Oct 30 00:05:59 UTC 2019 New revision: 516042 URL: https://svnweb.freebsd.org/changeset/ports/516042 Log: MFH: r515848 www/py-cheroot: Update to 6.5.6 * There is currently a signification amount of version churn in the upstream repository so use the most recent signed release for now. * Since release 6.3.0 the port installs a CLI tool outside the Python environment thus make it concurrent safe. * Also backport two patches to retain compatibility with recent versions of devel/py-setuptools and avoid failures at runtime with Python 3 while I'm here. [1] Changelog since 6.0.0: https://github.com/cherrypy/cheroot/blob/v6.5.6/CHANGES.rst PR: 241369 Submitted by: Keith Gaughan <k@stereochro.me> (maintainer) Approved by: Keith Gaughan <k@stereochro.me> (maintainer) [1] Approved by: ports-secteam (miwi) Changes: _U branches/2019Q4/ branches/2019Q4/www/py-cheroot/Makefile branches/2019Q4/www/py-cheroot/distinfo branches/2019Q4/www/py-cheroot/files/
Committed to the 2019Q4 branch, all done!