Bug 241505 - lang/clisp: Add devel/libffcall to LIB_DEPENDS
Summary: lang/clisp: Add devel/libffcall to LIB_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-26 16:32 UTC by Ting-Wei Lan
Modified: 2020-10-26 08:28 UTC (History)
3 users (show)

See Also:

Attachments
Patch (490 bytes, patch)
2019-10-26 16:32 UTC, Ting-Wei Lan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2019-10-26 16:32:50 UTC 
Created attachment 208610 [details]
Patch

devel/libffcall is currently a BUILD_DEPEND of lang/clisp, which suggests that it can be removed after the build. 'pkg autoremove' also lists libffcall as a package which can be removed. However, if you really remove libffcall, clisp will fail to run and 'pkg check' will complain there is a missing dependency.

$ clisp
ld-elf.so.1: Shared object "libffcall.so.0" not found, required by "lisp.run"

# pkg check -dn clisp
Checking clisp: 100%
clisp is missing a required shared library: libffcall.so.0

Fix it by adding devel/libffcall to LIB_DEPENDS.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2020-06-17 00:15:49 UTC 
pi: lang/clisp seems resurrected with a maintain but not the submitter in r498199. Are you sure it's right and should we still ask them feedback of this patch?
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2020-06-17 04:20:13 UTC 
We should ask both kiri@TrueFC.org and kiri@kx.openedu.org for feedback on this.
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2020-06-17 06:25:23 UTC 
Neither kiri@TrueFC.org nor kiri@kx.openedu.org has bugs.freebsd.org account. :-( Asked through email.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-10-26 08:23:24 UTC 
A commit references this bug:

Author: danfe
Date: Mon Oct 26 08:23:19 UTC 2020
New revision: 553323
URL: https://svnweb.freebsd.org/changeset/ports/553323

Log:
  Correct dependency on `devel/libffcall': clisp(1) actually links to
  `libffcall.so.0' shared library, and will not run if it is missing.

  PR:	241505

Changes:
  head/lang/clisp/Makefile
Comment 5 Alexey Dokuchaev freebsd_committer freebsd_triage 2020-10-26 08:26:14 UTC 
Fixed as of ports r553323, thanks for reporting!