Created attachment 208671 [details] py-streamlink-1.2.0.shar request update www/py-requests Bug #239302 request new port misc/py-iso-639 bug #241564 misc/py-iso3166 bug #241565 https://streamlink.github.io/
Review items: 1) pip, and test related dependencies (pytest, pytest-cov, codecov, coverage, mock, requests-mock, freezegun *at least*) should not be required as RUN_DEPENDS. Port dependencies should exactly match (including any version specifiers): setup.py:install_requires (RUN_DEPENDS) setup.py:setup_requires (BUILD_DEPENDS) setup.py:tests_require (TEST_DEPENDS) 2) python:build,run is the same as USES=python 3) MASTER_SITES should default to CHEESESHOP unless there is a compelling (temporary) reason to use an alternative source like GitHub, such as if LICENSE_FILE or tests are missing from PyPI source distribution.
Created attachment 208686 [details] py-streamlink-1.2.0.shar comment #1 1&2&3) Fixed. changed to py-iso-639 -> py-iso639
Need to revert py-iso369 change (see bug 241564 comment 3)
Created attachment 208690 [details] py-streamlink-1.2.0.shar bug #241564 comment #4 bug #241565 comment #1 Follow category changes.
Created attachment 209643 [details] py-streamlink-1.3.0.shar Version 1.3.0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240777
I was going to submit this myself after the update of py-urllib3, but looks like you beat me to it. However, I have a few issues with the Makefile for the port: * I feel the category should be multimedia, like livestreamer was, not net. * The dependency on security/py-cryptodome is missing. * It might not be necessary to list py-urllib as a direct dependency of streamlink because it is included by py-requests. * This doesn't handle the case of someone wanting to build a version of Streamlink for Python 2.7, that requires devel/py-futures, devel/py-singledispatch, devel/py-backports.shutil_get_terminal_size, as well as py-backports.shutil_which (not currently in the ports tree). Otherwise I look forward to getting this officially in the ports tree finally.
Created attachment 209713 [details] py-streamlink-1.3.0.shar (In reply to Naram Qashat from comment #7) category change net -> multimedia net/py-urllib3 Deleted as pointed out. Declared USES=python:3.5+ because Python2.7 is not considered.
Who can commit this?
1.3.1 is out since January. We should't commit old ports without good reason.
Created attachment 213354 [details] py-streamlink-1.3.1.shar Update 1.3.1
Created attachment 213355 [details] py-streamlink-1.3.1.shar Change category net->multimedia
Created attachment 213791 [details] minor edits to takefu's submission, sorts RUN_DEPENDS and adds NO_ARCH=yes minor touch-ups not requiring maintainer approval, just showing them for completeness
IMO ready to go, with one more edit to multimedia/Makefile: SUBDIRS+=streamlink - only waiting for 241565, and kevans@ is on it.
A commit references this bug: Author: mandree Date: Mon Apr 27 12:57:24 UTC 2020 New revision: 533133 URL: https://svnweb.freebsd.org/changeset/ports/533133 Log: New port multimedia/streamlink 1.4.1. ---------------------------------------------------------------------------- Streamlink is a command-line utility that pipes video streams from various services into a video player, such as VLC. The main purpose of Streamlink is to allow the user to avoid buggy and CPU heavy flash plugins but still be able to enjoy various streamed content. There is also an API available for developers who want access to the video stream data. This project was forked from Livestreamer, which is no longer maintained. WWW: https://streamlink.github.io/ ---------------------------------------------------------------------------- Over the original submission, add these changes: - limit to Python 3.5+ because 241566 was lacking the four requisites (one not even in the ports tree before) needed additionally on 2.7, and upstream deprecated Python 2.7 support - add support for make test (TEST_DEPENDS=, do-test:) - add a PYCOUNTRY port option with a "magic" default that will be enabled while textproc/py-iso3166 (new -> Bugzilla #241565) is missing and use py-country instead of py-iso-639 and py-iso3166. So this port no longer depends on PR 241565. PR: 241566 Submitted by: takefu@airport.fm (new maintainer) Changes: head/multimedia/Makefile head/multimedia/streamlink/ head/multimedia/streamlink/Makefile head/multimedia/streamlink/distinfo head/multimedia/streamlink/pkg-descr
I've updated the port to 1.4.1 and added a few items, see the commit message.
I've had to add py-pysocks as a requisite and also added (default enabled) FFMPEG and RTMPDUMP options with further run-depends. PORTREVISION=1, r533145, see https://streamlink.github.io/install.html#dependencies
Created attachment 213860 [details] minimal tox.ini for future reference For future reference, this is a minimal working tox.ini file. To use this in tests, copy it into ${WRKSRC} and then just run "tox". Also, in order to run tests from poudriere, you'd need to add a "-B" to ${PYTHON_CMD} and add a BUILD_DEPENDS=${RUN_DEPENDS} ${TEST_DEPENDS} line.
*** Bug 240777 has been marked as a duplicate of this bug. ***