Created attachment 209027 [details] vips.patch - Add OPTIONS for all supported formats. - Add HEIF format support - Support newer ImageMagick port and allow to switch to GraphicsMagick - Remove un-needed dependencies
Unless I'm reading yor patch incorrectly can you elaborate on the switch from GraphicsMagick to ImageMagick as default configuration?
Hello, thank you for your patch. I like it. I just have the same question, why moving the Magick dependency to ImageMagick? Is it better than GraphicsMagick in any way?
I can report a personal experience and a general opinion: - personal experience: with GraphicsMagick I cannot open any BMP file with vips, with ImageMagick I have no problems - general opinion: GraphicsMagick has been superior to ImageMagick for a while, but it looks like IM improved a lot and GM now lacks many features present in IM7 I cannot bring evidence for the latter, but the first point seems serious enough for the switch, and the fact that vips has a default on IM7 should mean something.
A commit references this bug: Author: danilo Date: Sun Nov 10 22:01:53 UTC 2019 New revision: 517234 URL: https://svnweb.freebsd.org/changeset/ports/517234 Log: - Convert hardcoded dependencies to options - Defaults magick to ImageMagick (vips uses it by default) PR: 241851 Submitted by: ale Changes: head/graphics/vips/Makefile
Committed. Thank you!
This seems to be some weird build issue, at least in the past: https://github.com/libvips/libvips/issues/851 fwiw, GraphicsMagick is still quite a bit faster than Image so it would be nice if this could be fixed rather than switching libraries. I can confirm the issue in my box.
That issue was related to the fact that vips wasn't actually built with GraphicsMagick support. BMP format is probably the most common format that is handled by magick library in vips. But in our case: Magick package: GraphicsMagick Magick API version: magick6 load with libMagick: yes save with libMagick: yes # ldd /usr/local/bin/vipsheader | grep Magick libGraphicsMagick.so.3 => /usr/local/lib/libGraphicsMagick.so.3 (0x800800000) # vipsheader /usr/local/share/xsl/docbook/slides/slidy/graphics/nofold-dim.bmp vipsheader: VipsForeignLoad: "/usr/local/share/xsl/docbook/slides/slidy/graphics/nofold-dim.bmp" is not a known file format So it's actually built with GM support, but it doesn't work as intended. As stated in such bug report the author doesn't use GM, so it's not really tested. Magick package: MagickCore Magick API version: magick7 load with libMagick: yes save with libMagick: yes # ldd /usr/local/bin/vipsheader | grep Magick libMagickCore-7.so.6 => /usr/local/lib/libMagickCore-7.so.6 (0x8007c0000) # vipsheader /usr/local/share/xsl/docbook/slides/slidy/graphics/nofold-dim.bmp /usr/local/share/xsl/docbook/slides/slidy/graphics/nofold-dim.bmp: 9x9 uchar, 3 bands, srgb, magickload